Skip to content

Commit 1ef4298

Browse files
committed
Addressing PR review comments
1 parent 6be70f6 commit 1ef4298

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ Then perform the following commands on the root folder:
117117
| mtu | The network MTU (If set to 0, meaning MTU is unset - defaults to '1460'). Recommended values: 1460 (default for historic reasons), 1500 (Internet default), or 8896 (for Jumbo packets). Allowed are all values in the range 1300 to 8896, inclusively. | `number` | `0` | no |
118118
| network\_firewall\_policy\_enforcement\_order | Set the order that Firewall Rules and Firewall Policies are evaluated. Valid values are `BEFORE_CLASSIC_FIREWALL` and `AFTER_CLASSIC_FIREWALL`. (default null or equivalent to `AFTER_CLASSIC_FIREWALL`) | `string` | `null` | no |
119119
| network\_name | The name of the network being created | `string` | n/a | yes |
120+
| network\_profile | "A full or partial URL of the network profile to apply to this network.<br>This field can be set only at resource creation time. For example, the<br>following are valid URLs:<br> * https://www.googleapis.com/compute/beta/projects/{projectId}/global/networkProfiles/{network_profile_name}<br> * projects/{projectId}/global/networkProfiles/{network\_profile\_name} | `string` | `null` | no |
120121
| project\_id | The ID of the project where this VPC will be created | `string` | n/a | yes |
121122
| routes | List of routes being created in this VPC | `list(map(string))` | `[]` | no |
122123
| routing\_mode | The network routing mode (default 'GLOBAL') | `string` | `"GLOBAL"` | no |

modules/vpc/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ module "vpc" {
3636
| mtu | The network MTU (If set to 0, meaning MTU is unset - defaults to '1460'). Recommended values: 1460 (default for historic reasons), 1500 (Internet default), or 8896 (for Jumbo packets). Allowed are all values in the range 1300 to 8896, inclusively. | `number` | `0` | no |
3737
| network\_firewall\_policy\_enforcement\_order | Set the order that Firewall Rules and Firewall Policies are evaluated. Valid values are `BEFORE_CLASSIC_FIREWALL` and `AFTER_CLASSIC_FIREWALL`. (default null or equivalent to `AFTER_CLASSIC_FIREWALL`) | `string` | `null` | no |
3838
| network\_name | The name of the network being created | `string` | n/a | yes |
39+
| network\_profile | "A full or partial URL of the network profile to apply to this network.<br>This field can be set only at resource creation time. For example, the<br>following are valid URLs:<br> * https://www.googleapis.com/compute/beta/projects/{projectId}/global/networkProfiles/{network_profile_name}<br> * projects/{projectId}/global/networkProfiles/{network\_profile\_name} | `string` | `null` | no |
3940
| project\_id | The ID of the project where this VPC will be created | `string` | n/a | yes |
4041
| routing\_mode | The network routing mode (default 'GLOBAL') | `string` | `"GLOBAL"` | no |
4142
| shared\_vpc\_host | Makes this project a Shared VPC host if 'true' (default 'false') | `bool` | `false` | no |

modules/vpc/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,10 @@ variable "network_profile" {
8282
type = string
8383
default = null
8484
description = <<-EOT
85-
"A full or partial URL of the network profile to apply to this network.
85+
"A full or partial URL of the network profile to apply to this network.
8686
This field can be set only at resource creation time. For example, the
8787
following are valid URLs:
8888
* https://www.googleapis.com/compute/beta/projects/{projectId}/global/networkProfiles/{network_profile_name}
8989
* projects/{projectId}/global/networkProfiles/{network_profile_name}
9090
EOT
91-
}
91+
}

modules/vpc/versions.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ terraform {
2424
}
2525
google-beta = {
2626
source = "hashicorp/google-beta"
27-
version = ">= 6.13.0, < 7"
27+
version = ">= 6.13, < 7"
2828
}
2929
}
3030

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ variable "network_profile" {
204204
type = string
205205
default = null
206206
description = <<-EOT
207-
"A full or partial URL of the network profile to apply to this network.
207+
"A full or partial URL of the network profile to apply to this network.
208208
This field can be set only at resource creation time. For example, the
209209
following are valid URLs:
210210
* https://www.googleapis.com/compute/beta/projects/{projectId}/global/networkProfiles/{network_profile_name}

0 commit comments

Comments
 (0)