fix: use for_each for shared VPC service project connections (#329)

BREAKING CHANGE: shared_vpc attachments in the `fabric-net-svpc-access` submodule have been refactored, changing the state location.

Author: nikhilmakhijani

modules/fabric-net-svpc-access/main.tf

@@ -15,11 +15,10 @@
  */
 
 resource "google_compute_shared_vpc_service_project" "projects" {
-  provider = google-beta
-
-  count           = var.service_project_num
+  provider        = google-beta
+  for_each        = { for i, k in toset(var.service_project_ids) : k => i }
   host_project    = var.host_project_id
-  service_project = element(var.service_project_ids, count.index)
+  service_project = each.key
 }
 
 resource "google_compute_subnetwork_iam_binding" "network_users" {

modules/fabric-net-svpc-access/outputs.tf

@@ -16,5 +16,7 @@
 
 output "service_projects" {
   description = "Project ids of the services with access to all subnets."
-  value       = google_compute_shared_vpc_service_project.projects.*.service_project
+  value = [
+    for i, k in google_compute_shared_vpc_service_project.projects : k.service_project
+  ]
 }