Skip to content

Commit bcd0a0c

Browse files
committed
fix service-account based egress rules
1 parent f4eff27 commit bcd0a0c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

modules/fabric-net-firewall/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ resource "google_compute_firewall" "custom" {
121121
destination_ranges = each.value.direction == "EGRESS" ? each.value.ranges : null
122122
source_tags = each.value.use_service_accounts || each.value.direction == "EGRESS" ? null : each.value.sources
123123
target_tags = each.value.use_service_accounts ? null : each.value.targets
124-
source_service_accounts = each.value.use_service_accounts ? each.value.sources : null
124+
source_service_accounts = each.value.use_service_accounts && each.value.direction == "INGRESS" ? each.value.sources : null
125125
target_service_accounts = each.value.use_service_accounts ? each.value.targets : null
126126
disabled = lookup(each.value.extra_attributes, "disabled", false)
127127
priority = lookup(each.value.extra_attributes, "priority", 1000)

0 commit comments

Comments
 (0)