Skip to content

chore: Update README.md #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

chore: Update README.md #595

merged 1 commit into from
Apr 2, 2025

Conversation

@harsh-singh-oxb
Copy link
Contributor

@harsh-singh-oxb harsh-singh-oxb commented Apr 2, 2025

As per the latest documentation:

Only one of max_throughput and max_instances can be specified. The use of max_throughput is discouraged in favor of max_instances.

If you are using both, you will get this error:

╷
│ Error: Conflicting configuration arguments
│ 
│   with module.serverless_connector.google_vpc_access_connector.connector_beta["ew4-serverless"],
│   on .terraform/modules/serverless_connector/modules/vpc-serverless-connector-beta/main.tf line 36, in resource "google_vpc_access_connector" "connector_beta":
│   36:   max_instances  = each.value.max_instances
│ 
│ "max_instances": conflicts with max_throughput
╵
╷
│ Error: Conflicting configuration arguments
│ 
│   with module.serverless_connector.google_vpc_access_connector.connector_beta["ew4-serverless"],
│   on .terraform/modules/serverless_connector/modules/vpc-serverless-connector-beta/main.tf line 37, in resource "google_vpc_access_connector" "connector_beta":
│   37:   max_throughput = each.value.max_throughput
│ 
│ "max_throughput": conflicts with max_instances

@harsh-singh-oxb
Update README.md
200be96 
Remove max_throughput
@harsh-singh-oxb harsh-singh-oxb requested review from a team and imrannayer as code owners April 2, 2025 10:23
@google-cla
Copy link

google-cla bot commented Apr 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@harsh-singh-oxb harsh-singh-oxb changed the title Update README.md [Fix] Update README.md Apr 2, 2025
@harsh-singh-oxb harsh-singh-oxb changed the title [Fix] Update README.md docs: Update README.md Apr 2, 2025
@imrannayer imrannayer changed the title docs: Update README.md chore: Update README.md Apr 2, 2025
@imrannayer imrannayer merged commit c5ee576 into terraform-google-modules:main Apr 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imrannayer imrannayer imrannayer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harsh-singh-oxb @imrannayer