From 0b84f2b8ada72143deb605243863d40eb938730c Mon Sep 17 00:00:00 2001 From: Nathaniel Waisbrot Date: Wed, 28 May 2025 15:06:08 -0400 Subject: [PATCH] fix(docs): Correct bgp_best_path_selection_mode default value The docs say that the default is `STANDARD` but it is `LEGACY`. Refs: #616 --- README.md | 2 +- modules/vpc/README.md | 2 +- modules/vpc/variables.tf | 2 +- variables.tf | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index f5478cd2d..756b246ec 100644 --- a/README.md +++ b/README.md @@ -112,7 +112,7 @@ Then perform the following commands on the root folder: |------|-------------|------|---------|:--------:| | auto\_create\_subnetworks | When set to true, the network is created in 'auto subnet mode' and it will create a subnet for each region automatically across the 10.128.0.0/9 address range. When set to false, the network is created in 'custom subnet mode' so the user can explicitly connect subnetwork resources. | `bool` | `false` | no | | bgp\_always\_compare\_med | If set to true, the Cloud Router will use MED values from the peer even if the AS paths differ. Default is false. | `bool` | `false` | no | -| bgp\_best\_path\_selection\_mode | Specifies the BGP best path selection mode. Valid values are `STANDARD` or `LEGACY`. Default is `STANDARD`. | `string` | `"LEGACY"` | no | +| bgp\_best\_path\_selection\_mode | Specifies the BGP best path selection mode. Valid values are `STANDARD` or `LEGACY`. Default is `LEGACY`. | `string` | `"LEGACY"` | no | | bgp\_inter\_region\_cost | Specifies the BGP inter-region cost mode. Valid values are `DEFAULT` or `ADD_COST_TO_MED`. | `string` | `null` | no | | delete\_default\_internet\_gateway\_routes | If set, ensure that all routes within the network specified whose names begin with 'default-route' and with a next hop of 'default-internet-gateway' are deleted | `bool` | `false` | no | | description | An optional description of this resource. The resource must be recreated to modify this field. | `string` | `""` | no | diff --git a/modules/vpc/README.md b/modules/vpc/README.md index 12e0e8097..09910278d 100644 --- a/modules/vpc/README.md +++ b/modules/vpc/README.md @@ -30,7 +30,7 @@ module "vpc" { |------|-------------|------|---------|:--------:| | auto\_create\_subnetworks | When set to true, the network is created in 'auto subnet mode' and it will create a subnet for each region automatically across the 10.128.0.0/9 address range. When set to false, the network is created in 'custom subnet mode' so the user can explicitly connect subnetwork resources. | `bool` | `false` | no | | bgp\_always\_compare\_med | If set to true, the Cloud Router will use MED values from the peer even if the AS paths differ. Default is false. | `bool` | `false` | no | -| bgp\_best\_path\_selection\_mode | Specifies the BGP best path selection mode. Valid values are `STANDARD` or `LEGACY`. Default is `STANDARD`. | `string` | `"LEGACY"` | no | +| bgp\_best\_path\_selection\_mode | Specifies the BGP best path selection mode. Valid values are `STANDARD` or `LEGACY`. Default is `LEGACY`. | `string` | `"LEGACY"` | no | | bgp\_inter\_region\_cost | Specifies the BGP inter-region cost mode. Valid values are `DEFAULT` or `ADD_COST_TO_MED`. | `string` | `null` | no | | delete\_default\_internet\_gateway\_routes | If set, ensure that all routes within the network specified whose names begin with 'default-route' and with a next hop of 'default-internet-gateway' are deleted | `bool` | `false` | no | | description | An optional description of this resource. The resource must be recreated to modify this field. | `string` | `""` | no | diff --git a/modules/vpc/variables.tf b/modules/vpc/variables.tf index 04a6e43c1..b4b24a7ef 100644 --- a/modules/vpc/variables.tf +++ b/modules/vpc/variables.tf @@ -98,7 +98,7 @@ variable "bgp_always_compare_med" { variable "bgp_best_path_selection_mode" { type = string - description = "Specifies the BGP best path selection mode. Valid values are `STANDARD` or `LEGACY`. Default is `STANDARD`." + description = "Specifies the BGP best path selection mode. Valid values are `STANDARD` or `LEGACY`. Default is `LEGACY`." default = "LEGACY" } diff --git a/variables.tf b/variables.tf index f5f6c7b9d..91c9ccac1 100644 --- a/variables.tf +++ b/variables.tf @@ -220,7 +220,7 @@ variable "bgp_always_compare_med" { variable "bgp_best_path_selection_mode" { type = string - description = "Specifies the BGP best path selection mode. Valid values are `STANDARD` or `LEGACY`. Default is `STANDARD`." + description = "Specifies the BGP best path selection mode. Valid values are `STANDARD` or `LEGACY`. Default is `LEGACY`." default = "LEGACY" }