Extract project services and provider configuration to calling module

Author: Jberlinsky

modules/project_cleanup/README.md

@@ -2,8 +2,20 @@
 
 This module schedules a job to clean up GCP projects older than a specified length of time, that match a particular key-value pair. This job runs every 5 minutes via Google Cloud Scheduled Functions. Please see the [utility's readme](./function_source/README.md) for more information as to its operation and configuration.
 
+## Requirements
+
+### App Engine
+
 Running this module requires an App Engine app in the specified project/region. More information is in the [root readme](../../README.md#app-engine).
 
+### Enabled Services
+
+The following services must be enabled on the project housing the cleanup function prior to invoking this module:
+
+- Cloud Functions (`cloudfunctions.googleapis.com`)
+- Cloud Scheduler (`cloudscheduler.googleapis.com`)
+- Cloud Resource Manager (`cloudresourcemanager.googleapis.com`)
+
 [^]: (autogen_docs_start)
 
 

modules/project_cleanup/main.tf

@@ -14,33 +14,6 @@
  * limitations under the License.
  */
 
-provider "google-beta" {
-  version = "~> 2.1"
-  project = "${var.project_id}"
-  region  = "${var.region}"
-}
-
-resource "google_project_service" "cloudfunctions" {
-  project                    = "${var.project_id}"
-  service                    = "cloudfunctions.googleapis.com"
-  disable_dependent_services = true
-  disable_on_destroy         = false
-}
-
-resource "google_project_service" "cloudscheduler" {
-  project                    = "${google_project_service.cloudfunctions.project}"
-  service                    = "cloudscheduler.googleapis.com"
-  disable_dependent_services = true
-  disable_on_destroy         = false
-}
-
-resource "google_project_service" "cloudresourcemanager" {
-  project                    = "${google_project_service.cloudscheduler.project}"
-  service                    = "cloudresourcemanager.googleapis.com"
-  disable_dependent_services = true
-  disable_on_destroy         = false
-}
-
 resource "google_service_account" "project_cleaner_function" {
   project      = "${var.project_id}"
   account_id   = "project-cleaner-function"
@@ -54,12 +27,8 @@ resource "google_organization_iam_member" "project_owner" {
 }
 
 module "scheduled_project_cleaner" {
-  providers = {
-    google = "google-beta"
-  }
-
   source                         = "../../"
-  project_id                     = "${google_project_service.cloudresourcemanager.project}"
+  project_id                     = "${var.project_id}"
   job_name                       = "project-cleaner"
   job_schedule                   = "*/5 * * * *"
   function_entry_point           = "CleanUpProjects"