fix(mysql): error 'backup retention should be > transaction log retention' on mysql replica

christophe-biguereau-believe · christophe-biguereau-believe · commit 659ad2e1aa84 · 2025-10-30T15:31:11.000+01:00
diff --git a/modules/mysql/read_replica.tf b/modules/mysql/read_replica.tf
@@ -55,6 +55,10 @@ resource "google_sql_database_instance" "replicas" {
       content {
         binary_log_enabled             = lookup(backup_configuration.value, "binary_log_enabled", null)
         transaction_log_retention_days = lookup(backup_configuration.value, "transaction_log_retention_days", null)
+        backup_retention_settings {
+          retained_backups = lookup(backup_configuration.value, "transaction_log_retention_days", 0) > 7 ? lookup(backup_configuration.value, "transaction_log_retention_days") + 1 : null
+          retention_unit   = "COUNT"
+        }
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,10 @@ resource "google_sql_database_instance" "replicas" {`
`55`	`55`	`content {`
`56`	`56`	`binary_log_enabled = lookup(backup_configuration.value, "binary_log_enabled", null)`
`57`	`57`	`transaction_log_retention_days = lookup(backup_configuration.value, "transaction_log_retention_days", null)`
	`58`	`+ backup_retention_settings {`
	`59`	`+ retained_backups = lookup(backup_configuration.value, "transaction_log_retention_days", 0) > 7 ? lookup(backup_configuration.value, "transaction_log_retention_days") + 1 : null`
	`60`	`+ retention_unit = "COUNT"`
	`61`	`+ }`
`58`	`62`	`}`
`59`	`63`	`}`
`60`	`64`