Skip to content

Commit a8a85e1

Browse files
committed
fix: add missing default null value for connection_pool_config
Signed-off-by: Quoc Trung HOANG <quoc-trung.hoang@webedia-group.com>
1 parent ed675cf commit a8a85e1

File tree

6 files changed

+6
-3
lines changed

6 files changed

+6
-3
lines changed

modules/mysql/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ module "mysql-db" {
5050
| additional\_users | A list of users to be created in your cluster. A random password would be set for the user if the `random_password` variable is set. | <pre>list(object({<br> name = string<br> password = string<br> random_password = bool<br> type = string<br> host = string<br> }))</pre> | `[]` | no |
5151
| availability\_type | The availability type for the master instance. Can be either `REGIONAL` or `null`. | `string` | `"REGIONAL"` | no |
5252
| backup\_configuration | The backup\_configuration settings subblock for the database settings | <pre>object({<br> binary_log_enabled = optional(bool, false)<br> enabled = optional(bool, false)<br> start_time = optional(string)<br> location = optional(string)<br> transaction_log_retention_days = optional(string)<br> retained_backups = optional(number)<br> retention_unit = optional(string)<br> })</pre> | `{}` | no |
53-
| connection\_pool\_config | Manager connection pooling configuration | <pre>object({<br> enabled = optional(bool, false)<br> flags = optional(list(object({<br> name = string<br> value = string<br> })), [])<br> })</pre> | n/a | yes |
53+
| connection\_pool\_config | Manager connection pooling configuration | <pre>object({<br> enabled = optional(bool, false)<br> flags = optional(list(object({<br> name = string<br> value = string<br> })), [])<br> })</pre> | `null` | no |
5454
| connector\_enforcement | Enforce that clients use the connector library | `bool` | `false` | no |
5555
| create\_timeout | The optional timout that is applied to limit long database creates. | `string` | `"30m"` | no |
5656
| data\_cache\_enabled | Whether data cache is enabled for the instance. Defaults to false. Feature is only available for ENTERPRISE\_PLUS tier and supported database\_versions | `bool` | `false` | no |

modules/mysql/variables.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -516,4 +516,5 @@ variable "connection_pool_config" {
516516
value = string
517517
})), [])
518518
})
519+
default = null
519520
}

modules/postgresql/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ module "pg" {
121121
| additional\_users | A list of users to be created in your cluster. A random password would be set for the user if the `random_password` variable is set. | <pre>list(object({<br> name = string<br> password = string<br> random_password = bool<br> }))</pre> | `[]` | no |
122122
| availability\_type | The availability type for the Cloud SQL instance.This is only used to set up high availability for the PostgreSQL instance. Can be either `ZONAL` or `REGIONAL`. | `string` | `"ZONAL"` | no |
123123
| backup\_configuration | The backup\_configuration settings subblock for the database settings | <pre>object({<br> enabled = optional(bool, false)<br> start_time = optional(string)<br> location = optional(string)<br> point_in_time_recovery_enabled = optional(bool, false)<br> transaction_log_retention_days = optional(string)<br> retained_backups = optional(number)<br> retention_unit = optional(string)<br> })</pre> | `{}` | no |
124-
| connection\_pool\_config | Manager connection pooling configuration | <pre>object({<br> enabled = optional(bool, false)<br> flags = optional(list(object({<br> name = string<br> value = string<br> })), [])<br> })</pre> | n/a | yes |
124+
| connection\_pool\_config | Manager connection pooling configuration | <pre>object({<br> enabled = optional(bool, false)<br> flags = optional(list(object({<br> name = string<br> value = string<br> })), [])<br> })</pre> | `null` | no |
125125
| connector\_enforcement | Enforce that clients use the connector library | `bool` | `false` | no |
126126
| create\_kms\_key\_handle | KeyHandles cannot be deleted from Google Cloud Platform. Destroying a Terraform-managed KeyHandle will remove it from state but will not delete the resource from the project. Set this to false if key handle already exists | `bool` | `true` | no |
127127
| create\_timeout | The optional timout that is applied to limit long database creates. | `string` | `"30m"` | no |

modules/postgresql/variables.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -525,4 +525,5 @@ variable "connection_pool_config" {
525525
value = string
526526
})), [])
527527
})
528+
default = null
528529
}

modules/safer_mysql/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ module "safer-mysql-db" {
245245
| assign\_public\_ip | Set to true if the master instance should also have a public IP (less secure). | `bool` | `false` | no |
246246
| availability\_type | The availability type for the master instance. Can be either `REGIONAL` or `null`. | `string` | `"REGIONAL"` | no |
247247
| backup\_configuration | The backup\_configuration settings subblock for the database settings | <pre>object({<br> binary_log_enabled = bool<br> enabled = bool<br> start_time = string<br> location = string<br> transaction_log_retention_days = string<br> retained_backups = number<br> retention_unit = string<br> })</pre> | <pre>{<br> "binary_log_enabled": false,<br> "enabled": false,<br> "location": null,<br> "retained_backups": null,<br> "retention_unit": null,<br> "start_time": null,<br> "transaction_log_retention_days": null<br>}</pre> | no |
248-
| connection\_pool\_config | Manager connection pooling configuration | <pre>object({<br> enabled = optional(bool, false)<br> flags = optional(list(object({<br> name = string<br> value = string<br> })), [])<br> })</pre> | n/a | yes |
248+
| connection\_pool\_config | Manager connection pooling configuration | <pre>object({<br> enabled = optional(bool, false)<br> flags = optional(list(object({<br> name = string<br> value = string<br> })), [])<br> })</pre> | `null` | no |
249249
| create\_timeout | The optional timout that is applied to limit long database creates. | `string` | `"30m"` | no |
250250
| data\_cache\_enabled | Whether data cache is enabled for the instance. Defaults to false. Feature is only available for ENTERPRISE\_PLUS tier and supported database\_versions | `bool` | `false` | no |
251251
| database\_flags | The database flags for the master instance. See [more details](https://cloud.google.com/sql/docs/mysql/flags) | <pre>list(object({<br> name = string<br> value = string<br> }))</pre> | `[]` | no |

modules/safer_mysql/variables.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,4 +436,5 @@ variable "connection_pool_config" {
436436
value = string
437437
})), [])
438438
})
439+
default = null
439440
}

0 commit comments

Comments
 (0)