disk_size variable is only used at instance creation

[philip-harvey]

TL;DR

disk_size variable is only used at instance creation. Subsequent changes to the disk size are ignored.

Expected behavior

Increasing disk size passed to the module should increase the disk size of the instance if disk__autoresize is false.
Decreasing disk size passed to the module should delete and recreate the instance if deletion_protection is set to false

Observed behavior

disk_size is ignored by the module

Terraform Configuration

disk_size = 100
disk_autoresize = false

Terraform Version

Tested with Terraform 1.2.3

Additional information

Issue was previously reported as #148 and was closed without being fixed

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[philip-harvey]

Not stale

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[g-awmalik]

@philip-harvey - this is reasonable and I've added this to the backlog. However, if you're able to create a PR for us to review, that sure will speed things up. Thanks.

[g-awmalik]

Dependent on hashicorp/terraform#24188.

Since Cloud SQL can auto-size the disk space, we'll need to set ignore changes in the lifecycle block dynamically so it continue to ignore it when disk_autoresize is set to true and honors the change when it is false.

Until dynamic blocks are support for lifecycle, we'll need to continue to ignore changes to the disk size.