feat(compute_instance): added a variable to add/remove the hostname suffix for compute instance submodule (#177)

* [compute_instance] adding an optional var to override the generated hostname

* Removing override var and adding a var for the suffix

Author: jeenx

modules/compute_instance/README.md

@@ -16,6 +16,7 @@ See the [simple](https://github.com/terraform-google-modules/terraform-google-vm
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | access\_config | Access configurations, i.e. IPs via which the VM instance can be accessed via the Internet. | <pre>list(object({<br>    nat_ip       = string<br>    network_tier = string<br>  }))</pre> | `[]` | no |
+| add\_hostname\_suffix | Adds a suffix to the hostname | `bool` | `true` | no |
 | hostname | Hostname of instances | `string` | `""` | no |
 | instance\_template | Instance template self\_link used to create compute instances | `any` | n/a | yes |
 | network | Network to deploy to. Only one of network or subnetwork should be specified. | `string` | `""` | no |

modules/compute_instance/main.tf

@@ -41,7 +41,7 @@ data "google_compute_zones" "available" {
 resource "google_compute_instance_from_template" "compute_instance" {
   provider = google
   count    = local.num_instances
-  name     = "${local.hostname}-${format("%03d", count.index + 1)}"
+  name     = var.add_hostname_suffix ? "${local.hostname}-${format("%03d", count.index + 1)}" : local.hostname
   project  = local.project_id
   zone     = var.zone == null ? data.google_compute_zones.available.names[count.index % length(data.google_compute_zones.available.names)] : var.zone
 

modules/compute_instance/variables.tf

@@ -34,6 +34,11 @@ variable "hostname" {
   default     = ""
 }
 
+variable "add_hostname_suffix" {
+  description = "Adds a suffix to the hostname"
+  default     = true
+}
+
 variable "static_ips" {
   type        = list(string)
   description = "List of static IPs for VM instances"