Add tests for instance_templates and statically define assertions in MIG tests

Author: Simon So

modules/instance_template/main.tf

@@ -64,6 +64,6 @@ resource "google_compute_instance_template" "tpl" {
   }
 
   lifecycle {
-    create_before_destroy = true
+    create_before_destroy = "true"
   }
 }

modules/mig/main.tf

@@ -47,7 +47,7 @@ resource "google_compute_region_instance_group_manager" "mig" {
   update_policy             = ["${var.update_policy}"]
 
   lifecycle {
-    create_before_destroy = true
+    create_before_destroy = "true"
   }
 }
 

test/fixtures/mig/autoscaler/main.tf

@@ -31,7 +31,7 @@ module "mig_autoscaler" {
     environment = "dev"
   }
 
-  autoscaling_enabled = true
+  autoscaling_enabled = "true"
   min_replicas        = 4
 
   autoscaling_cpu = [{

test/integration/mig_autoscaler/controls/mig_autoscaler.rb

@@ -44,27 +44,75 @@
       end
     end
 
-    describe "network tags" do
+    describe "network tags for instance 1" do
       it "should include 'foo'" do
-        data.each do |instance|
-          expect(instance['tags']['items']).to include("foo")
-        end
+        expect(data[0]['tags']['items']).to include("foo")
       end
     end
 
-    describe "labels" do
+    describe "network tags for instance 2" do
+      it "should include 'foo'" do
+        expect(data[1]['tags']['items']).to include("foo")
+      end
+    end
+
+    describe "network tags for instance 3" do
+      it "should include 'foo'" do
+        expect(data[2]['tags']['items']).to include("foo")
+      end
+    end
+
+    describe "network tags for instance 4" do
+      it "should include 'foo'" do
+        expect(data[3]['tags']['items']).to include("foo")
+      end
+    end
+
+    describe "labels for instance 1" do
+      it "should include 'environment' key" do
+        expect(data[0]['labels']).to include("environment")
+      end
+    end
+
+    describe "labels for instance 2" do
+      it "should include 'environment' key" do
+        expect(data[1]['labels']).to include("environment")
+      end
+    end
+
+    describe "labels for instance 3" do
       it "should include 'environment' key" do
-        data.each do |instance|
-          expect(instance['labels']).to include("environment")
-        end
+        expect(data[2]['labels']).to include("environment")
+      end
+    end
+
+    describe "labels for instance 4" do
+      it "should include 'environment' key" do
+        expect(data[3]['labels']).to include("environment")
+      end
+    end
+
+    describe "labels for instance 1" do
+      it "'environment' should have value 'dev'" do
+        expect(data[0]['labels']['environment']).to eq("dev")
+      end
+    end
+
+    describe "labels for instance 2" do
+      it "'environment' should have value 'dev'" do
+        expect(data[1]['labels']['environment']).to eq("dev")
+      end
+    end
+
+    describe "labels for instance 3" do
+      it "'environment' should have value 'dev'" do
+        expect(data[2]['labels']['environment']).to eq("dev")
       end
     end
 
-    describe "labels" do
+    describe "labels for instance 4" do
       it "'environment' should have value 'dev'" do
-        data.each do |instance|
-          expect(instance['labels']['environment']).to eq("dev")
-        end
+        expect(data[3]['labels']['environment']).to eq("dev")
       end
     end
 

test/integration/mig_simple/controls/mig_simple.rb

@@ -34,7 +34,7 @@
       if subject.exit_status == 0
         JSON.parse(subject.stdout)
       else
-        []]
+        []
       end
     end
 
@@ -44,27 +44,75 @@
       end
     end
 
-    describe "network tags" do
+    describe "network tags for instance 1" do
+      it "should include 'foo'" do
+        expect(data[0]['tags']['items']).to include("foo")
+      end
+    end
+
+    describe "network tags for instance 2" do
       it "should include 'foo'" do
-        data.each do |instance|
-          expect(instance['tags']['items']).to include("foo")
-        end
+        expect(data[1]['tags']['items']).to include("foo")
       end
     end
 
-    describe "labels" do
+    describe "network tags for instance 3" do
+      it "should include 'foo'" do
+        expect(data[2]['tags']['items']).to include("foo")
+      end
+    end
+
+    describe "network tags for instance 4" do
+      it "should include 'foo'" do
+        expect(data[3]['tags']['items']).to include("foo")
+      end
+    end
+
+    describe "labels for instance 1" do
       it "should include 'environment' key" do
-        data.each do |instance|
-          expect(instance['labels']).to include("environment")
-        end
+        expect(data[0]['labels']).to include("environment")
+      end
+    end
+
+    describe "labels for instance 2" do
+      it "should include 'environment' key" do
+        expect(data[1]['labels']).to include("environment")
+      end
+    end
+
+    describe "labels for instance 3" do
+      it "should include 'environment' key" do
+        expect(data[2]['labels']).to include("environment")
+      end
+    end
+
+    describe "labels for instance 4" do
+      it "should include 'environment' key" do
+        expect(data[3]['labels']).to include("environment")
+      end
+    end
+
+    describe "labels for instance 1" do
+      it "'environment' should have value 'dev'" do
+        expect(data[0]['labels']['environment']).to eq("dev")
+      end
+    end
+
+    describe "labels for instance 2" do
+      it "'environment' should have value 'dev'" do
+        expect(data[1]['labels']['environment']).to eq("dev")
+      end
+    end
+
+    describe "labels for instance 3" do
+      it "'environment' should have value 'dev'" do
+        expect(data[2]['labels']['environment']).to eq("dev")
       end
     end
 
-    describe "labels" do
+    describe "labels for instance 4" do
       it "'environment' should have value 'dev'" do
-        data.each do |instance|
-          expect(instance['labels']['environment']).to eq("dev")
-        end
+        expect(data[3]['labels']['environment']).to eq("dev")
       end
     end