Validate missing required inputs for second level and higher dependencies #1055
Description
Description
Current addons test code only validates if there are some missing inputs for top tile and direct dependencies. For second level and higher dependencies it was incorrectly finding the first level dependency which has the best matching name and this logic has flaws. We ended up seeing missing inputs for a DA which doesn't even has that input. Reference Issue
Although we only interact with first level dependencies and all dependent repos have their own tests this may not be required but we can implement additional checks.
Suggested Approach:
- Make a list of all unique AddonConfigs including top level config and while validating a config match the locatorID field with the AddonConfig having same versionLocator and get the catalogID as it a direct field of AddonConfig Object and offeringID and versionID can be fetched from versionLocator of the AddonConfig.
- Get the Offering for this AddonConfig using existing function GetOffering(catalogID,offeringID)
- Get OfferingInputs for this AddonConfig using existing function GetOfferingInputs(offering,versionID,offeringID)
- Validate the inputs
Current validateRequiredInputs only works till first level dependencies as OfferingInputs are set only for first level dependency in SetOfferingDetails function, hence we need separate logic.
New or affected modules
By submitting this issue, you agree to follow our Code of Conduct