Skip to content

Commit 8327b04

Browse files
authored
feat: Added the following new inputs:<br>- existing_secrets_manager_crn - for optionally using an existing secrets manager<br>- enable_platform_logs_metrics - to enable/disable platform logging and monitoing since only 1 platform instance is allowed per region in an account. (#32)
1 parent 3caac19 commit 8327b04

File tree

2 files changed

+36
-13
lines changed

2 files changed

+36
-13
lines changed

stack_definition.json

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,23 @@
5050
"hidden": false,
5151
"default": "security-compliance-center-standard-plan",
5252
"custom_config": {}
53-
}
53+
},
54+
{
55+
"name": "existing_secrets_manager_crn",
56+
"required": false,
57+
"type": "string",
58+
"hidden": false,
59+
"default": "__NULL__",
60+
"custom_config": {}
61+
},
62+
{
63+
"name": "enable_platform_logs_metrics",
64+
"required": false,
65+
"type": "boolean",
66+
"hidden": false,
67+
"default": true,
68+
"custom_config": {}
69+
}
5470
],
5571
"members": [
5672
{
@@ -104,7 +120,15 @@
104120
{
105121
"name": "prefix",
106122
"value": "ref:../../inputs/prefix"
107-
}
123+
},
124+
{
125+
"name": "enable_platform_logs",
126+
"value": "ref:../../inputs/enable_platform_logs_metrics"
127+
},
128+
{
129+
"name": "enable_platform_metrics",
130+
"value": "ref:../../inputs/enable_platform_logs_metrics"
131+
}
108132
],
109133
"name": "3 - core-security-observability",
110134
"version_locator": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3.dbb2626f-f6d7-498c-9a89-3a0b69997b8a-global"
@@ -219,6 +243,10 @@
219243
"name": "existing_event_notification_instance_crn",
220244
"value": "ref:../../members/2 - core-security-services-en/outputs/crn"
221245
},
246+
{
247+
"name": "existing_secrets_manager_crn",
248+
"value": "ref:../../inputs/existing_secrets_manager_crn"
249+
},
222250
{
223251
"name": "service_plan",
224252
"value": "ref:../../inputs/sm_service_plan"

tests/pr_test.go

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,13 @@ func TestProjectsFullTest(t *testing.T) {
1313
Prefix: "cs", // setting prefix here gets a random string appended to it
1414
ParallelDeploy: true,
1515
})
16-
17-
options.StackMemberInputs = map[string]map[string]interface{}{
18-
"3 - core-security-observability": {
19-
"enable_platform_logs": false,
20-
},
21-
}
2216
options.StackInputs = map[string]interface{}{
23-
"prefix": options.Prefix,
24-
"resource_group_name": options.Prefix,
25-
"sm_service_plan": "trial",
26-
"use_existing_resource_group": false,
27-
"ibmcloud_api_key": options.RequiredEnvironmentVars["TF_VAR_ibmcloud_api_key"], // always required by the stack
17+
"prefix": options.Prefix,
18+
"resource_group_name": options.Prefix,
19+
"sm_service_plan": "trial",
20+
"use_existing_resource_group": false,
21+
"ibmcloud_api_key": options.RequiredEnvironmentVars["TF_VAR_ibmcloud_api_key"], // always required by the stack
22+
"enable_platform_logs_metrics": false,
2823
}
2924

3025
err := options.RunProjectsTest()

0 commit comments

Comments
 (0)