Skip to content

Commit 9869b55

Browse files
author
Md Anam Raihan
committed
fix: resolve comments
1 parent c8300aa commit 9869b55

File tree

2 files changed

+60
-60
lines changed

2 files changed

+60
-60
lines changed

ibm_catalog.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -289,21 +289,21 @@
289289
"key": "cis_id",
290290
"type": "string",
291291
"default_value": "__NULL__",
292-
"description": "Cloud Internet Service ID. Required if secret_manager_public_engine_enabled is set to true",
292+
"description": "Cloud Internet Service ID. Required if `secret_manager_public_engine_enabled` is set to true.",
293293
"required": false
294294
},
295295
{
296296
"key": "ca_name",
297297
"type": "string",
298298
"default_value": "__NULL__",
299-
"description": "The name of the certificate authority for Secrets Manager. Required if secret_manager_public_engine_enabled is set to true",
299+
"description": "The name of the certificate authority for Secrets Manager. Required if `secret_manager_public_engine_enabled` is set to true.",
300300
"required": false
301301
},
302302
{
303303
"key": "dns_provider_name",
304304
"type": "string",
305-
"default_value": "certificate-dns",
306-
"description": "The name of the DNS provider for the public certificate secrets engine configuration.",
305+
"default_value": "__NULL__",
306+
"description": "The name of the DNS provider for the public certificate secrets engine configuration. Required if `secret_manager_public_engine_enabled` is set to true.",
307307
"required": false
308308
},
309309
{

stack_definition.json

Lines changed: 56 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -79,62 +79,62 @@
7979
"default": "security-compliance-center-standard-plan",
8080
"custom_config": {}
8181
},
82-
{
83-
"name": "secret_manager_iam_engine_enabled",
84-
"required": false,
85-
"type": "boolean",
86-
"hidden": false,
87-
"default": false,
88-
"custom_config": {}
89-
},
90-
{
91-
"name": "secret_manager_public_engine_enabled",
92-
"required": false,
93-
"type": "boolean",
94-
"hidden": false,
95-
"default": false,
96-
"custom_config": {}
97-
},
98-
{
99-
"name": "existing_secrets_endpoint_type",
100-
"required": false,
101-
"type": "string",
102-
"hidden": false,
103-
"default": "private",
104-
"custom_config": {}
105-
},
106-
{
107-
"name": "cis_id",
108-
"required": false,
109-
"type": "string",
110-
"hidden": false,
111-
"default": "__NULL__",
112-
"custom_config": {}
113-
},
114-
{
115-
"name": "ca_name",
116-
"required": false,
117-
"type": "string",
118-
"hidden": false,
119-
"default": "__NULL__",
120-
"custom_config": {}
121-
},
122-
{
123-
"name": "dns_provider_name",
124-
"required": false,
125-
"type": "string",
126-
"hidden": false,
127-
"default": "__NULL__",
128-
"custom_config": {}
129-
},
130-
{
131-
"name": "acme_letsencrypt_private_key",
132-
"required": false,
133-
"type": "string",
134-
"hidden": true,
135-
"default": "__NULL__",
136-
"custom_config": {}
137-
}
82+
{
83+
"name": "secret_manager_iam_engine_enabled",
84+
"required": false,
85+
"type": "boolean",
86+
"hidden": false,
87+
"default": false,
88+
"custom_config": {}
89+
},
90+
{
91+
"name": "secret_manager_public_engine_enabled",
92+
"required": false,
93+
"type": "boolean",
94+
"hidden": false,
95+
"default": false,
96+
"custom_config": {}
97+
},
98+
{
99+
"name": "existing_secrets_endpoint_type",
100+
"required": false,
101+
"type": "string",
102+
"hidden": false,
103+
"default": "private",
104+
"custom_config": {}
105+
},
106+
{
107+
"name": "cis_id",
108+
"required": false,
109+
"type": "string",
110+
"hidden": false,
111+
"default": "__NULL__",
112+
"custom_config": {}
113+
},
114+
{
115+
"name": "ca_name",
116+
"required": false,
117+
"type": "string",
118+
"hidden": false,
119+
"default": "__NULL__",
120+
"custom_config": {}
121+
},
122+
{
123+
"name": "dns_provider_name",
124+
"required": false,
125+
"type": "string",
126+
"hidden": false,
127+
"default": "__NULL__",
128+
"custom_config": {}
129+
},
130+
{
131+
"name": "acme_letsencrypt_private_key",
132+
"required": false,
133+
"type": "string",
134+
"hidden": true,
135+
"default": "__NULL__",
136+
"custom_config": {}
137+
}
138138
],
139139
"members": [
140140
{

0 commit comments

Comments
 (0)