feat: added support to enable the secrets manager public cert engine #100
Conversation
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
ibm_catalog.json
Outdated
| "key": "cis_id", | ||
| "type": "string", | ||
| "default_value": "__NULL__", | ||
| "description": "Cloud Internet Service ID.", |
There was a problem hiding this comment.
Assuming Conall is correct, include,
...Applies only if secret_manager_public_engine_enabled is true.
Or if always required as he asks, include,
...Required if secret_manager_public_engine_enabled is set to true.
For the rest of the description, is it some ID for the instance or something else. Probably need more details -- perhaps about where to find it if it's not clear to most non-developers.
ibm_catalog.json
Outdated
| "key": "acme_letsencrypt_private_key", | ||
| "type": "string", | ||
| "default_value": "__NULL__", | ||
| "description": "The private key generated by the ACME account creation tool.", |
There was a problem hiding this comment.
do client in the Cloud catalog know what the ACME tool is? If not, add
For more information, see... and use a markdown link (
[]()) to a doc topic about the tool.
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
@iamar7 I approved, but I do have one suggestion. |
Co-authored-by: Allen Dean <[email protected]>
|
/run pipeline |
|
/run pipeline |
|
@iamar7 The tests are blocked in this repo due to IBM-Cloud/terraform-provider-ibm#5586 |
|
FYI, the pipeline is unblocked here |
|
/run pipeline |
|
/run pipeline |
|
As discussed internally, we are not going to expose all these new variables, but instead document how a user can achieve this by directly update the secrets manager member DA inside the stack. I think that documentation would live in https://cloud.ibm.com/docs/security-services?topic=security-services-css-relnotes somewhere, so please work with @SirSpidey on that. Since there is no code changes needed in the repo, I'm going to close this PR. |
Description
#59
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers