Skip to content

Conversation

@smguilia
Copy link
Contributor

@smguilia smguilia commented Nov 19, 2024

Updates for formatting / fix sentence

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Updates for formatting / fix sentence
@smguilia
Copy link
Contributor Author

Updates included:

  1. The docs related to this DA moved into the security hub as part of platform simplification.
  2. The indentions are to fix formatting issues as the page is not building correctly in the doc framework
  3. I also proposed an update to the phrasing around SCC. The way it is in there now doesn't make sense to me. But, please read closely and be sure I didn't change anything that shouldn't be changed.

@ocofaigh
Copy link
Contributor

/run pipeline

@ocofaigh ocofaigh merged commit edf58be into terraform-ibm-modules:main Nov 21, 2024
2 checks passed
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants