-
Notifications
You must be signed in to change notification settings - Fork 5
restrict tests to eu-de #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
stack_definition.json
Outdated
| "type": "string", | ||
| "hidden": false, | ||
| "default": "us-south", | ||
| "default": "eu-de", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't change this - it will mean consumers using default values will end up recreating all resources in a new region. I think its fine to leave as us-south and override in test
tests/pr_test.go
Outdated
| // Current supported regions (NOTE: eu-es is not being used as we don't have extended trial plan quota in that region currently) | ||
| var validRegions = []string{ | ||
| "us-south", | ||
| // "us-south", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to link to the issue which explains why we are using 1 region
|
/run pipeline |
|
error: |
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
part of: https://github.ibm.com/GoldenEye/issues/issues/12725
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers