Skip to content

Conversation

@alex-reiff
Copy link
Contributor

@alex-reiff alex-reiff commented Mar 19, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@alex-reiff
Copy link
Contributor Author

/run pipeline

"type": "string",
"hidden": false,
"default": "us-south",
"default": "eu-de",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change this - it will mean consumers using default values will end up recreating all resources in a new region. I think its fine to leave as us-south and override in test

tests/pr_test.go Outdated
// Current supported regions (NOTE: eu-es is not being used as we don't have extended trial plan quota in that region currently)
var validRegions = []string{
"us-south",
// "us-south",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to link to the issue which explains why we are using 1 region

@alex-reiff
Copy link
Contributor Author

/run pipeline

@alex-reiff
Copy link
Contributor Author

error:

 2025/03/19 17:57:35 Terraform apply | 
 2025/03/19 17:57:35 Terraform apply | Warning: Argument is deprecated
 2025/03/19 17:57:35 Terraform apply | 
 2025/03/19 17:57:35 Terraform apply |   with module.cos_bucket[0].module.buckets["cs-gecfgr-cloud-logs-metrics-bucket"].ibm_cos_bucket.cos_bucket[0],
 2025/03/19 17:57:35 Terraform apply |   on .terraform/modules/cos_bucket/main.tf line 160, in resource "ibm_cos_bucket" "cos_bucket":
 2025/03/19 17:57:35 Terraform apply |  160: resource "ibm_cos_bucket" "cos_bucket" {
 2025/03/19 17:57:35 Terraform apply | 
 2025/03/19 17:57:35 Terraform apply | Use the ibm_cos_bucket_lifecycle_configuration resource instead
 2025/03/19 17:57:35 Terraform apply | 
 2025/03/19 17:57:35 Terraform apply | (and 13 more similar warnings elsewhere)
 2025/03/19 17:57:35 Terraform apply | 
 2025/03/19 17:57:35 Terraform apply | Error: CreateTargetWithContext failed Your request to test a target has failed because the target details are not valid. The service could not write to the IBM Cloud Logs instance that is configured, because of CloudlogsWriteTest write test has failed with bad status code 500.
 2025/03/19 17:57:35 Terraform apply | {
 2025/03/19 17:57:35 Terraform apply |     "StatusCode": 400,
 2025/03/19 17:57:35 Terraform apply |     "Headers": {
 2025/03/19 17:57:35 Terraform apply |         "Cache-Control": [
 2025/03/19 17:57:35 Terraform apply |             "no-store, no-cache, must-revalidate, private, max-age=0"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Cf-Cache-Status": [
 2025/03/19 17:57:35 Terraform apply |             "DYNAMIC"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Cf-Ray": [
 2025/03/19 17:57:35 Terraform apply |             "922eda42b9eabee7-LHR"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Content-Length": [
 2025/03/19 17:57:35 Terraform apply |             "368"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Content-Security-Policy": [
 2025/03/19 17:57:35 Terraform apply |             "default-src 'none'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; connect-src 'self'; img-src 'self' data:; style-src 'self' 'unsafe-inline'; font-src 'self'"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Content-Type": [
 2025/03/19 17:57:35 Terraform apply |             "application/json; charset=utf-8"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Cross-Origin-Opener-Policy": [
 2025/03/19 17:57:35 Terraform apply |             "same-origin"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Cross-Origin-Resource-Policy": [
 2025/03/19 17:57:35 Terraform apply |             "same-origin"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Date": [
 2025/03/19 17:57:35 Terraform apply |             "Wed, 19 Mar 2025 17:57:35 GMT"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Expires": [
 2025/03/19 17:57:35 Terraform apply |             "Wed, 19 Mar 2025 17:57:30 GMT"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Referrer-Policy": [
 2025/03/19 17:57:35 Terraform apply |             "no-referrer"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Server": [
 2025/03/19 17:57:35 Terraform apply |             "cloudflare"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Set-Cookie": [
 2025/03/19 17:57:35 Terraform apply |             "__cfruid=24885cf7894b6cec5603fd487648c362d6c8b53d-1742407055; path=/; domain=.eu-de.atracker.cloud.ibm.com; HttpOnly; Secure; SameSite=None"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "Strict-Transport-Security": [
 2025/03/19 17:57:35 Terraform apply |             "max-age=31557600; includeSubDomains"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "X-Content-Type-Options": [
 2025/03/19 17:57:35 Terraform apply |             "nosniff"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "X-Correlation-Id": [
 2025/03/19 17:57:35 Terraform apply |             "1522d5f2-9fef-4d86-85fc-d765fe522aec"
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "X-Request-Id": [
 2025/03/19 17:57:35 Terraform apply |             "fc2ef97e-6e1d-4781-b18f-256be9fbe8bc"
 2025/03/19 17:57:35 Terraform apply |         ]
 2025/03/19 17:57:35 Terraform apply |     },
 2025/03/19 17:57:35 Terraform apply |     "Result": {
 2025/03/19 17:57:35 Terraform apply |         "errors": [
 2025/03/19 17:57:35 Terraform apply |             {
 2025/03/19 17:57:35 Terraform apply |                 "code": "cloudlogs_write_test_failed",
 2025/03/19 17:57:35 Terraform apply |                 "message": "Your request to test a target has failed because the target details are not valid. The service could not write to the IBM Cloud Logs instance that is configured, because of CloudlogsWriteTest write test has failed with bad status code 500."
 2025/03/19 17:57:35 Terraform apply |             }
 2025/03/19 17:57:35 Terraform apply |         ],
 2025/03/19 17:57:35 Terraform apply |         "status_code": 400,
 2025/03/19 17:57:35 Terraform apply |         "trace": "fc2ef97e-6e1d-4781-b18f-256be9fbe8bc"
 2025/03/19 17:57:35 Terraform apply |     },
 2025/03/19 17:57:35 Terraform apply |     "RawResult": null
 2025/03/19 17:57:35 Terraform apply | }
 2025/03/19 17:57:35 Terraform apply | 
 2025/03/19 17:57:35 Terraform apply | 
 2025/03/19 17:57:35 Terraform apply |   with module.observability_instance.module.activity_tracker.ibm_atracker_target.atracker_cloud_logs_targets["cs-gecfgr-cloud-logs-target"],
 2025/03/19 17:57:35 Terraform apply |   on .terraform/modules/observability_instance/modules/activity_tracker/main.tf line 84, in resource "ibm_atracker_target" "atracker_cloud_logs_targets":
 2025/03/19 17:57:35 Terraform apply |   84: resource "ibm_atracker_target" "atracker_cloud_logs_targets" {
 2025/03/19 17:57:35 Terraform apply | 

@ocofaigh ocofaigh merged commit 2fae750 into main Mar 20, 2025
1 of 2 checks passed
@ocofaigh ocofaigh deleted the region branch March 20, 2025 10:27
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants