fix: add extra stack outputs and inputs #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/run pipeline |
4 similar comments
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
daniel-butler-irl
previously approved these changes
Oct 4, 2024
Contributor
daniel-butler-irl
left a comment
daniel-butler-irl
left a comment
There was a problem hiding this comment.
Stack defs look good, you might want someone else to take a look at the diagram, I cannot comment if is correct or not
Contributor
|
@akocbek Can we try get this ready for merge? |
ocofaigh
requested changes
Nov 28, 2024
| }, | ||
| { | ||
| "name": "log_analysis_guid", | ||
| "value": "ref:../members/Essential Security - Logging Monitoring Activity Tracker/outputs/log_analysis_guid" |
Contributor
There was a problem hiding this comment.
remove log_analysis_crn and log_analysis_guid - the stack no longer deploys log analysis
akocbek
force-pushed
the
inputs_outputs
branch
from
2bebd98 to
3501681
Compare
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
2 similar comments
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
|
The pipeline is failing due to known issues with projects race condition. I'm doing a manual test using your branch, and if the outputs look good, Ill proceed to force merge this |
akocbek
force-pushed
the
inputs_outputs
branch
from
f5a89df to
fb8d6bf
Compare
ocofaigh
approved these changes
Dec 4, 2024
Contributor
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issues:
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers