fully configurable #255
Merged
fully configurable #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatagarwal-ibm
requested review from
daniel-butler-irl and
ocofaigh
as code owners
Member
Author
|
Variation used for "Accounts Infrastructure Base" is |
Member
Author
|
Member
Author
|
Updated elasticsearch_version to 8.15 from 8.12 |
Member
Author
|
focuses on the |
Member
Author
|
Able to deploy this version |
Contributor
|
@rajatagarwal-ibm similar test updates also needed in pr_test.go |
ocofaigh
requested changes
Oct 1, 2025
Contributor
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
- Your code doesn't seem to handle the
existing_resource_group_nameuse case. Current DA supports this, but defaults to creating new resource groups. We may want to revisit this and refactor based on best user experience. - Rename
existing_event_notification_instance_crn->existing_event_notifications_instance_crn - Rename
existing_discovery_instance->existing_discovery_instance_crn - Rename
existing_governance_instance->existing_governance_instance_crn - Rename
existing_studio_instance->existing_studio_instance_crn - Update
prefixdescription to align the this guidance, and remove the default value - Rename the output
event_notification_instance_crn->event_notifications_instance_crn - Rename the output
event_notification_instance_name->event_notifications_instance_name - Rename the output
event_notifications_instance_guid->event_notifications_instance_guid - We should be able to support more regions than
us-southandeu-de? I think some watson services were not supported in all regions, but we should check now and update
ocofaigh
requested changes
Oct 1, 2025
Contributor
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
Just noticed the diagram needs an update - it still references the legacy SCC
ocofaigh
approved these changes
Oct 3, 2025
Contributor
|
/run pipeline |
ocofaigh
requested changes
Oct 3, 2025
Contributor
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
Update .catalog-onboard-pipeline.yaml with new variation name
Contributor
|
/run pipeline |
Contributor
|
/run pipeline |
ocofaigh
previously approved these changes
Oct 6, 2025
6 tasks
Contributor
|
/run pipeline |
Contributor
|
/run pipeline |
Contributor
|
/run pipeline |
1 similar comment
Contributor
|
/run pipeline |
6 tasks
Contributor
|
/run pipeline |
Contributor
|
/run pipeline |
ocofaigh
approved these changes
Nov 5, 2025
Contributor
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers