Skip to content

Conversation

@imprateeksh
Copy link
Member

@imprateeksh imprateeksh commented Nov 11, 2025

Description

fixes: #247

This PR addresses issue to include two new variations without sample app and devops alm.
Also, addressing two other issues to update the diagram and to document the known limitation with the RAG stack.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@imprateeksh
Copy link
Member Author

image

@imprateeksh
Copy link
Member Author

Seeing Projects failure while adding to catalog - https://ibm-cloudplatform.slack.com/archives/C03554X40G3/p1762856522691989

@ocofaigh
Copy link
Contributor

ocofaigh commented Nov 17, 2025

@imprateeksh can you get this up to date with the changes that went into v5.0.1 please?

@imprateeksh
Copy link
Member Author

Unable to test - Getting failures while adding to new project or using existing project.
image

@ocofaigh
Copy link
Contributor

@imprateeksh I thought even though you hit that error in the UI, the project still gets created?

@imprateeksh
Copy link
Member Author

imprateeksh commented Nov 18, 2025

@imprateeksh I thought even though you hit that error in the UI, the project still gets created?

Yes that is correct observation Conall. Only difference is last time there was no configuration added and this time we do have the configuration. I am already checking that.

@imprateeksh
Copy link
Member Author

Deployment is successful (error message is wrongly shown) -
image

@imprateeksh
Copy link
Member Author

In Progress - Metadata should be same for the ibmcatalog.json present here and for quickstart variation from cloud-native-ai repo.

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Also the diagram colours seem odd. Do they show like this for you? Also you should add App Configuration in the same line as SCC-WP

Image

@imprateeksh
Copy link
Member Author

imprateeksh commented Nov 20, 2025

Few comments. Also the diagram colours seem odd. Do they show like this for you? Also you should add App Configuration in the same line as SCC-WP
Image

I think I was facing some color issue in diagram and from newer stencils icons unable to pick the image present in boundary. Let me update this once again.


Update - Found the reason for this behavior, there is a setting in draw.io, to disable adaptive colors with which the appearance is same in different themes. Changed from default to None

image

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn’t seem to be tests added for the new variations?

@ocofaigh
Copy link
Contributor

Alternatively we could write a test that ensures all of the code in the new variations matches the code in the current variations. Then we wouldn't need to add more tests that provision resources. perhaps create a follow up issue for that? I don't want to hold this Pr up any longer

@ocofaigh
Copy link
Contributor

@imprateeksh I have one request to push to this PR please. Can you:

  1. Bump to latest git submodule git submodule update --remote --merge
  2. Delete the symlink: rm -f .pre-commit-config.yaml
  3. Recreate it using ln -s common-dev-assets/module-assets/.pre-commit-config.yaml .pre-commit-config.yaml
  4. Run pre-commit run --all-files and fix any failing hooks

ocofaigh
ocofaigh previously approved these changes Nov 25, 2025
@ocofaigh ocofaigh merged commit aabe7d6 into main Nov 25, 2025
@ocofaigh ocofaigh deleted the rag-new-variations branch November 25, 2025 14:57
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OCP variation of RAG stack is not idempotent (ACL rules managed by two different DAs)

4 participants