-
Notifications
You must be signed in to change notification settings - Fork 13
feat: add new variations without sample app #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Seeing Projects failure while adding to catalog - https://ibm-cloudplatform.slack.com/archives/C03554X40G3/p1762856522691989 |
|
@imprateeksh can you get this up to date with the changes that went into v5.0.1 please? |
…/stack-retrieval-augmented-generation into rag-new-variations
|
@imprateeksh I thought even though you hit that error in the UI, the project still gets created? |
Yes that is correct observation Conall. Only difference is last time there was no configuration added and this time we do have the configuration. I am already checking that. |
|
In Progress - Metadata should be same for the |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn’t seem to be tests added for the new variations?
|
Alternatively we could write a test that ensures all of the code in the new variations matches the code in the current variations. Then we wouldn't need to add more tests that provision resources. perhaps create a follow up issue for that? I don't want to hold this Pr up any longer |
|
@imprateeksh I have one request to push to this PR please. Can you:
|
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |






Description
fixes: #247
This PR addresses issue to include two new variations without sample app and devops alm.
Also, addressing two other issues to update the diagram and to document the known limitation with the RAG stack.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers