Skip to content

Conversation

@iamar7
Copy link
Member

@iamar7 iamar7 commented Sep 22, 2025

Description

Issue: https://github.ibm.com/GoldenEye/issues/issues/15220

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7 iamar7 requested a review from vkuma17 as a code owner September 22, 2025 06:50
@iamar7
Copy link
Member Author

iamar7 commented Sep 22, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 23, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 23, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 23, 2025

  • prefix
  • existing_cloud_logs_instance_crn
Screenshot 2025-09-23 at 18 40 22
  • existing_cos_instance_crn
Screenshot 2025-09-23 at 18 55 55
  • existing_cos_kms_key_crn
  • existing_monitoring_crn
  • existing_kms_instance_crn
Screenshot 2025-09-23 at 18 54 19

@iamar7 iamar7 self-assigned this Sep 24, 2025
vkuma17
vkuma17 previously approved these changes Sep 25, 2025
@iamar7
Copy link
Member Author

iamar7 commented Sep 25, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 25, 2025

  • prefix
  • existing_cloud_logs_instance_crn
Screenshot 2025-09-23 at 18 40 22 * `existing_cos_instance_crn` Screenshot 2025-09-23 at 18 55 55 * `existing_cos_kms_key_crn` * `existing_monitoring_crn` * `existing_kms_instance_crn` Screenshot 2025-09-23 at 18 54 19

Some of the screenshots has incorrect grammer in the error_message (in not valid) which I have already corrected and updated it to (is not valid).

@iamar7 iamar7 requested a review from vkuma17 September 25, 2025 09:37
@ocofaigh ocofaigh merged commit 649ae4b into main Sep 26, 2025
2 checks passed
@ocofaigh ocofaigh deleted the 15220-regex branch September 26, 2025 12:45
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants