Skip to content

remove account config dep #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 17, 2025
Merged

remove account config dep #117

merged 10 commits into from
Oct 17, 2025
+49 −11

Conversation

@daniel-butler-irl
Copy link
Contributor

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

ocofaigh
ocofaigh requested changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump to cloud logs v1.9.0

ibm_catalog.json Outdated
}
]
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might fail hook?

@ocofaigh
Copy link
Contributor

Waiting for Cloud Logs v1.9.0 to be published before running tests

@ocofaigh ocofaigh marked this pull request as ready for review October 17, 2025 12:07
@ocofaigh ocofaigh requested a review from iamar7 as a code owner October 17, 2025 12:07
ocofaigh
ocofaigh previously approved these changes Oct 17, 2025
View reviewed changes
ocofaigh
ocofaigh reviewed Oct 17, 2025
View reviewed changes
@daniel-butler-irl
Copy link
Contributor Author

/run pipeline

ocofaigh
ocofaigh previously approved these changes Oct 17, 2025
View reviewed changes
@daniel-butler-irl
Copy link
Contributor Author

/run pipeline

ocofaigh
ocofaigh previously approved these changes Oct 17, 2025
View reviewed changes
@daniel-butler-irl
Copy link
Contributor Author

/run pipeline

ocofaigh
ocofaigh requested changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test wrapper version needs to be bumped to latest. The test is stuck due to manual validation enabled:

Image

@ocofaigh ocofaigh merged commit fc9e2bf into main Oct 17, 2025
1 of 2 checks passed
@ocofaigh ocofaigh deleted the remove_ac_dep branch October 17, 2025 15:12
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@iamar7 iamar7 Awaiting requested review from iamar7 iamar7 is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daniel-butler-irl @ocofaigh @terraform-ibm-modules-ops