- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
Migration of activity tracker from observability-instances #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Readme changes are remaining  | 
    
| 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
        
          
                main.tf
              
                Outdated
          
        
      | target_service_name = "cloud-object-storage" | ||
| target_resource_instance_id = regex(".*:(.*)::", each.value.instance_id)[0] | ||
| roles = ["Object Writer"] | ||
| description = "Permit AT service Object Writer access to COS instance ${each.value.instance_id}" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamar7 Have we tried scoping the auth policy to the exact bucket? Like we do in cloud logs module for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocofaigh i have made the change and successfully tested it.
| 
           /run pipeline  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit hook failing
| 
           /run pipeline  | 
    
| 
           🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀  | 
    
Description
Migrate Activity Tracker Event Routing code from the observability-instances repo has been moved here and examples for this module created.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers