Skip to content

Conversation

@iamar7
Copy link
Member

@iamar7 iamar7 commented Apr 15, 2025

Description

Migrate Activity Tracker Event Routing code from the observability-instances repo has been moved here and examples for this module created.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7 iamar7 self-assigned this Apr 15, 2025
@iamar7
Copy link
Member Author

iamar7 commented Apr 15, 2025

Readme changes are remaining

@iamar7
Copy link
Member Author

iamar7 commented Apr 17, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Apr 17, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Apr 17, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Apr 21, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Apr 24, 2025

/run pipeline

main.tf Outdated
target_service_name = "cloud-object-storage"
target_resource_instance_id = regex(".*:(.*)::", each.value.instance_id)[0]
roles = ["Object Writer"]
description = "Permit AT service Object Writer access to COS instance ${each.value.instance_id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamar7 Have we tried scoping the auth policy to the exact bucket? Like we do in cloud logs module for example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocofaigh i have made the change and successfully tested it.

@ocofaigh
Copy link
Contributor

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit hook failing

@vkuma17
Copy link
Contributor

vkuma17 commented Apr 28, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 8d97461 into main Apr 28, 2025
2 checks passed
@ocofaigh ocofaigh deleted the 12595-at branch April 28, 2025 15:59
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants