Skip to content

Conversation

@vkuma17
Copy link
Contributor

@vkuma17 vkuma17 commented Apr 28, 2025

Description

feat: Added DA code

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@vkuma17 vkuma17 requested review from iamar7 and shemau as code owners April 28, 2025 17:00
@vkuma17
Copy link
Contributor Author

vkuma17 commented Apr 28, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Apr 28, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per the issue details, the AT DA needs to support creating a cloud logs instance just for AT events. It should also optionally support using an existing instance

@iamar7
Copy link
Member

iamar7 commented May 6, 2025

Why are we removing the test TestRunBasicExample, TestRunAdvancedExample & TestRunUpgradeExample? We can remove TestRunUpgradeExample and move others to other_tests.go?

@vkuma17
Copy link
Contributor Author

vkuma17 commented May 7, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented May 7, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented May 7, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Jun 26, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Jun 26, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Jun 26, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Jun 26, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Jun 26, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Jun 26, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Jun 26, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Jun 26, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Jun 27, 2025

/run pipeline

@iamar7
Copy link
Member

iamar7 commented Jun 27, 2025

/run pipeline

@iamar7
Copy link
Member

iamar7 commented Jun 27, 2025

Pipeline is failing due to this error which is not related to the changes made in the module. Re-running

  2025/06/27 09:29:41 Terraform apply | Error: InvalidRequest: Server Side Encryption with hs-crypto is not enabled.
         2025/06/27 09:29:41 Terraform apply | 	status code: 400, request id: 7c023c4e-9353-4ea6-9d6d-a7a056e84d29, host id: 
         2025/06/27 09:29:41 Terraform apply | 
         2025/06/27 09:29:41 Terraform apply |   with module.cos_bucket[0].module.buckets["at-fc-skifuq-at-events-cos-bucket"].ibm_cos_bucket.cos_bucket[0],
         2025/06/27 09:29:41 Terraform apply |   on .terraform/modules/cos_bucket/main.tf line 122, in resource "ibm_cos_bucket" "cos_bucket":
         2025/06/27 09:29:41 Terraform apply |  122: resource "ibm_cos_bucket" "cos_bucket" {
         2025/06/27 09:29:41 Terraform apply | 
         2025/06/27 09:29:41 Terraform apply | ---
         2025/06/27 09:29:41 Terraform apply | id: terraform-d2853781
         2025/06/27 09:29:41 Terraform apply | summary: "InvalidRequest: Server Side Encryption with hs-crypto is not
         2025/06/27 09:29:41 Terraform apply | enabled.\n\tstatus
         2025/06/27 09:29:41 Terraform apply |   code: 400, request id: 7c023c4e-9353-4ea6-9d6d-a7a056e84d29, host id: "
         2025/06/27 09:29:41 Terraform apply | severity: error
         2025/06/27 09:29:41 Terraform apply | resource: ibm_cos_bucket
         2025/06/27 09:29:41 Terraform apply | operation: create
         2025/06/27 09:29:41 Terraform apply | component:
         2025/06/27 09:29:41 Terraform apply |   name: github.com/IBM-Cloud/terraform-provider-ibm
         2025/06/27 09:29:41 Terraform apply |   version: 1.79.0
         2025/06/27 09:29:41 Terraform apply | ---
         2025/06/27 09:29:41 Terraform apply | 

Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh ocofaigh merged commit 891dc2e into main Jun 27, 2025
2 checks passed
@ocofaigh ocofaigh deleted the at-da branch June 27, 2025 17:15
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants