fix: remove global event routing settings configuration from advance example

[iamar7]

Description

Remove global event routing settings configuration from advance example
Resolves: #26

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[iamar7]

/run pipeline

[iamar7]

This is an expected failure since I am removing atracker_settings from the example

=== NAME  TestRunUpgradeExample
    terraform.go:236: 
        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/[email protected]/testhelper/terraform.go:236
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/[email protected]/testhelper/tests.go:541
        	            				/__w/terraform-ibm-activity-tracker/terraform-ibm-activity-tracker/tests/pr_test.go:70
        	Error:      	Should be false
        	Test:       	TestRunUpgradeExample
        	Messages:   	Resource(s) identified to be destroyed 
        	            	Name: atracker_settings
        	            	Address: module.activity_tracker.ibm_atracker_settings.atracker_settings[0]
        	            	Actions: [delete]
        	            	DIFF:
        	            	Error getting diff: missing 'before' or 'after' key in JSON
        	            	
        	            	Change Detail:
        	            	{
        	            	  "actions": [
        	            	    "delete"
        	            	  ],
        	            	  "after_sensitive": false,
        	            	  "after_unknown": {},
        	            	  "before": {
        	            	    "api_version": 2,
        	            	    "default_targets": "SECURE_VALUE_HIDDEN_HASH:-e6783f8fd8596d9734dc76e0d29ce1c63732ac31f66641151ae0c595",
        	            	    "id": "us-south",
        	            	    "message": "Setting audit log can be found in the region it is being called from and the route and target audit logs can be found in the metadata primary region.",
        	            	    "metadata_region_backup": null,
        	            	    "metadata_region_primary": "us-south",
        	            	    "permitted_target_regions": "SECURE_VALUE_HIDDEN_HASH:-3efc6dc9e1a7b79ac512c70e3195cff58fea3bb85c0c370d783b8623",
        	            	    "private_api_endpoint_only": false
        	            	  },
        	            	  "before_sensitive": {
        	            	    "default_targets": [
        	            	      false,
        	            	      false,
        	            	      false
        	            	    ],
        	            	    "permitted_target_regions": [
        	            	      false,
        	            	      false,
        	            	      false,
        	            	      false,
        	            	      false,
        	            	      false,
        	            	      false,
        	            	      false,
        	            	      false,
        	            	      false,
        	            	      false,
        	            	      false,
        	            	      false
        	            	    ]
        	            	  }
        	            	}

[iamar7]

/run pipeline

[iamar7]

/run pipeline

[ocofaigh]

This description is far too long. Such a description should exist in the example as that is where consumers go to see the usage

[ocofaigh]

see comment

[iamar7]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀