fix: updated cloud log mapping

[Khuzaima05]

Description

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[ocofaigh]

Any update? This is currently blocking some other DAs from consuming new Observability DAs

[Khuzaima05]

Any update? This is currently blocking some other DAs from consuming new Observability DAs

I’m testing in the project by creating a tile using this branch. I’ll also try using same tile as an add-on in one of the DAs for further testing.

[Khuzaima05]

/run pipeline

[ocofaigh]

I don't think you need to map existing_kms_instance_crn and existing_kms_key_crn in the Cloud Logs dependency config - Cloud logs DA will have its own mapping to KMS already.
I think the same might be true for existing_cos_instance_crn - Cloud Logs DA already has its own mapping for COS.

Can we do some testing to confirm this?

[Khuzaima05]

/run pipeline

[Khuzaima05]

/run pipeline

[ocofaigh]

deploy-arch-ibm-account-infra-base should not be a dependant DA - the AT DA doesn’t use resource group like we discussed yesterday

[Khuzaima05]

/run pipeline

[ocofaigh]

See comment

[Khuzaima05]

/run pipeline

[ocofaigh]

We need to make the exact same changes for COS:

• enable_activity_tracker_event_routing_to_cos_bucket should be false in the terraform DA code, and we should set it to true in the mapping if COS DA is enabled
• Variable validation should be added for existing_cos_instance_crn to make sure its not null if enable_activity_tracker_event_routing_to_cos_bucket is true

[Khuzaima05]

/run pipeline

[iamar7]

@ocofaigh If we have enabled it to true, wouldn't the catalog validation while publishing the tile will fail based on the validation we just added?

[ocofaigh]

No we are creating ICL and COS in tests/resources/main.tf

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.2.11 🎉

The release is available on:

• GitHub release
• v1.2.11

Your semantic-release bot 📦🚀