Skip to content

refactor: added add-on test and description update #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 5, 2025
Merged

refactor: added add-on test and description update #83

merged 9 commits into from
Sep 5, 2025

Conversation

@Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Aug 20, 2025 •
edited
Loading

Description

Added the default and permutation add-ons testing to pr_test
issue : https://github.ibm.com/GoldenEye/issues/issues/15591

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05 Khuzaima05 self-assigned this Aug 20, 2025
@Khuzaima05
Copy link
Member Author

/run pipeline

1 similar comment
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 marked this pull request as ready for review August 28, 2025 06:21
@Khuzaima05
Copy link
Member Author

/run pipeline

Khuzaima-Shakeel added 2 commits September 4, 2025 09:51
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 changed the title feat: added add-on test feat: added add-on test and description update Sep 4, 2025
iamar7
iamar7 reviewed Sep 4, 2025
View reviewed changes
@Khuzaima05 @iamar7
Update tests/pr_test.go
ead6610 
Co-authored-by: Md Anam Raihan <[email protected]>
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 changed the title feat: added add-on test and description update refactor: added add-on test and description update Sep 5, 2025
iamar7
iamar7 approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh ocofaigh merged commit 16e4640 into main Sep 5, 2025
2 checks passed
@ocofaigh ocofaigh deleted the issue_15591 branch September 5, 2025 10:41
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.2.26 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamar7 iamar7 iamar7 approved these changes

@vkuma17 vkuma17 Awaiting requested review from vkuma17

Assignees

@Khuzaima05 Khuzaima05

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Khuzaima05 @terraform-ibm-modules-ops @iamar7 @ocofaigh