-
Notifications
You must be signed in to change notification settings - Fork 0
Update provider version and test source #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
Since the event-streams module requires a minimum IBM provider version of 1.79.2, both the basic and advanced examples require 1.79.2 as the minimum. However, the solution does not include event-streams as a target, so it is being deployed with version 1.79.0. Therefore, I’m planning to update the minimum required version in the basic example to 1.79.2 and will add a comment referencing this issue as the reason. |
|
/run pipeline |
shemau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This is a change to a test and an example. I can not see why a release is required. |
Updated the release notes |
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Update provider version and test source
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers