From 2c2f836e0df29d5412dd6357dc029989718f26ec Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Thu, 7 Aug 2025 14:16:17 +0530 Subject: [PATCH 01/10] fix: updated cloud log mapping --- ibm_catalog.json | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/ibm_catalog.json b/ibm_catalog.json index bbf0d71e..6a507a0f 100644 --- a/ibm_catalog.json +++ b/ibm_catalog.json @@ -155,14 +155,6 @@ } ] }, - { - "key": "cloud_logs_instance_name", - "required": true, - "type": "string", - "description": "Name of the cloud logs instance to be created.", - "virtual": true, - "default_value": "__NOT_SET__" - }, { "key": "existing_cloud_logs_instance_crn" }, @@ -409,14 +401,9 @@ ], "id": "63d8ae58-fbf3-41ce-b844-0fb5b85882ab-global", "version": "v1.5.6", - "optional": true, + "optional": false, "on_by_default": true, "input_mapping": [ - { - "dependency_input": "cloud_logs_instance_name", - "version_input": "cloud_logs_instance_name", - "reference_version": true - }, { "dependency_input": "existing_cos_instance_crn", "version_input": "existing_cos_instance_crn", From c0ed4e3a40f03306b3d1bc89a31249a0f6e31082 Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Tue, 12 Aug 2025 19:56:20 +0530 Subject: [PATCH 02/10] update version --- ibm_catalog.json | 39 ++++++------------- .../catalogValidationValues.json.template | 3 +- solutions/fully-configurable/main.tf | 11 ------ solutions/fully-configurable/variables.tf | 8 ---- 4 files changed, 13 insertions(+), 48 deletions(-) diff --git a/ibm_catalog.json b/ibm_catalog.json index 06634049..27d79a36 100644 --- a/ibm_catalog.json +++ b/ibm_catalog.json @@ -111,7 +111,11 @@ "required": true }, { - "key": "existing_resource_group_name" + "key": "existing_resource_group_name", + "type": "string", + "description": "Name of the existing resource group to be used.", + "virtual": true, + "default_value": "__NOT_SET__" }, { "key": "region", @@ -156,7 +160,8 @@ ] }, { - "key": "existing_cloud_logs_instance_crn" + "key": "existing_cloud_logs_instance_crn", + "required": true }, { "key": "enable_activity_tracker_event_routing_to_cloud_logs" @@ -311,7 +316,7 @@ "name": "deploy-arch-ibm-cos", "description": "Enable this to create an IBM Cloud Object Storage(COS) instance. The buckets to store events will be created by the Activity Tracker Event Routing deployable architecture.", "id": "68921490-2778-4930-ac6d-bae7be6cd958-global", - "version": "v9.0.2", + "version": "v10.2.1", "flavors": [ "instance" ], @@ -339,7 +344,7 @@ "name": "deploy-arch-ibm-kms", "description": "Enable when you want to create your own managed keys to encrypt the buckets. Select only if existing KMS instance or Key is not provided. ", "id": "2cad4789-fa90-4886-9c9e-857081c273ee-global", - "version": "v5.1.4", + "version": "v5.1.19", "flavors": [ "fully-configurable" ], @@ -400,35 +405,15 @@ "fully-configurable" ], "id": "63d8ae58-fbf3-41ce-b844-0fb5b85882ab-global", - "version": "v1.5.6", - "optional": false, + "version": "v1.6.11", + "optional": true, "on_by_default": true, "input_mapping": [ - { - "dependency_input": "existing_cos_instance_crn", - "version_input": "existing_cos_instance_crn", - "reference_version": true - }, { "dependency_input": "existing_monitoring_crn", "version_input": "existing_monitoring_crn", "reference_version": true }, - { - "dependency_input": "existing_kms_instance_crn", - "version_input": "existing_kms_instance_crn", - "reference_version": true - }, - { - "dependency_input": "kms_encryption_enabled_buckets", - "version_input": "kms_encryption_enabled_buckets", - "reference_version": true - }, - { - "dependency_input": "existing_kms_key_crn", - "version_input": "existing_cos_kms_key_crn", - "reference_version": true - }, { "dependency_input": "prefix", "version_input": "prefix", @@ -449,7 +434,7 @@ "name": "deploy-arch-ibm-cloud-monitoring", "description": "Enable IBM Cloud Monitoring to gain operational visibility into your cloud storage buckets. ", "id": "73debdbf-894f-4c14-81c7-5ece3a70b67d-global", - "version": "v1.3.0", + "version": "v1.6.4", "flavors": [ "fully-configurable" ], diff --git a/solutions/fully-configurable/catalogValidationValues.json.template b/solutions/fully-configurable/catalogValidationValues.json.template index 67ee17ba..5911cc0f 100644 --- a/solutions/fully-configurable/catalogValidationValues.json.template +++ b/solutions/fully-configurable/catalogValidationValues.json.template @@ -4,6 +4,5 @@ "kms_encryption_enabled_buckets": true, "region": "us-south", "prefix": $PREFIX, - "existing_cos_instance_crn": $COS_INSTANCE_CRN, - "existing_resource_group_name": "geretain-test-resources" + "existing_cos_instance_crn": $COS_INSTANCE_CRN } diff --git a/solutions/fully-configurable/main.tf b/solutions/fully-configurable/main.tf index ba7e3012..04a14db8 100644 --- a/solutions/fully-configurable/main.tf +++ b/solutions/fully-configurable/main.tf @@ -76,17 +76,6 @@ locals { } -####################################################################################################################### -# Resource Group -####################################################################################################################### - -module "resource_group" { - source = "terraform-ibm-modules/resource-group/ibm" - version = "1.3.0" - existing_resource_group_name = var.existing_resource_group_name -} - - ####################################################################################################################### # Activity Tracker ####################################################################################################################### diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf index c1e18572..6b58f4db 100644 --- a/solutions/fully-configurable/variables.tf +++ b/solutions/fully-configurable/variables.tf @@ -22,14 +22,6 @@ variable "ibmcloud_kms_api_key" { default = null } - -variable "existing_resource_group_name" { - type = string - description = "The name of an existing resource group to provision the resources. If not provided the default resource group will be used." - default = null -} - - variable "region" { type = string description = "The region to provision all resources in. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/region) about how to select different regions for different services." From 5e6b0db1252eebd645f449c68022e143f243106d Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Tue, 12 Aug 2025 23:03:03 +0530 Subject: [PATCH 03/10] updated description --- ibm_catalog.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ibm_catalog.json b/ibm_catalog.json index 27d79a36..857e45e8 100644 --- a/ibm_catalog.json +++ b/ibm_catalog.json @@ -113,7 +113,7 @@ { "key": "existing_resource_group_name", "type": "string", - "description": "Name of the existing resource group to be used.", + "description": "Name of the existing resource group where add-ons will be deployed.", "virtual": true, "default_value": "__NOT_SET__" }, From a57eadc1b8a43db53f12ec5fabf7aef028ff31da Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Tue, 12 Aug 2025 23:21:15 +0530 Subject: [PATCH 04/10] updated default value --- ibm_catalog.json | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/ibm_catalog.json b/ibm_catalog.json index 857e45e8..c1ce94c9 100644 --- a/ibm_catalog.json +++ b/ibm_catalog.json @@ -115,7 +115,7 @@ "type": "string", "description": "Name of the existing resource group where add-ons will be deployed.", "virtual": true, - "default_value": "__NOT_SET__" + "default_value": "__NULL__" }, { "key": "region", @@ -317,9 +317,7 @@ "description": "Enable this to create an IBM Cloud Object Storage(COS) instance. The buckets to store events will be created by the Activity Tracker Event Routing deployable architecture.", "id": "68921490-2778-4930-ac6d-bae7be6cd958-global", "version": "v10.2.1", - "flavors": [ - "instance" - ], + "flavors": ["instance"], "catalog_id": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3", "optional": true, "on_by_default": true, @@ -345,9 +343,7 @@ "description": "Enable when you want to create your own managed keys to encrypt the buckets. Select only if existing KMS instance or Key is not provided. ", "id": "2cad4789-fa90-4886-9c9e-857081c273ee-global", "version": "v5.1.19", - "flavors": [ - "fully-configurable" - ], + "flavors": ["fully-configurable"], "catalog_id": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3", "optional": true, "on_by_default": true, @@ -401,9 +397,7 @@ "name": "deploy-arch-ibm-cloud-logs", "description": "Enable this to create an IBM Cloud Logs (ICL) Instance which can be used for storage and analysis of events ingested by Activity Tracker. ", "catalog_id": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3", - "flavors": [ - "fully-configurable" - ], + "flavors": ["fully-configurable"], "id": "63d8ae58-fbf3-41ce-b844-0fb5b85882ab-global", "version": "v1.6.11", "optional": true, @@ -435,9 +429,7 @@ "description": "Enable IBM Cloud Monitoring to gain operational visibility into your cloud storage buckets. ", "id": "73debdbf-894f-4c14-81c7-5ece3a70b67d-global", "version": "v1.6.4", - "flavors": [ - "fully-configurable" - ], + "flavors": ["fully-configurable"], "catalog_id": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3", "optional": true, "on_by_default": true, @@ -541,15 +533,11 @@ "iam_permissions": [ { "service_name": "All account management services", - "role_crns": [ - "crn:v1:bluemix:public:iam::::role:Administrator" - ] + "role_crns": ["crn:v1:bluemix:public:iam::::role:Administrator"] }, { "service_name": "atracker", - "role_crns": [ - "crn:v1:bluemix:public:iam::::role:Administrator" - ] + "role_crns": ["crn:v1:bluemix:public:iam::::role:Administrator"] } ], "architecture": { From 6709f2b37c21fcc0bb7b6df019f8d14802b2c167 Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Wed, 13 Aug 2025 00:14:24 +0530 Subject: [PATCH 05/10] updated pr test --- tests/pr_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/pr_test.go b/tests/pr_test.go index 51963948..b3bb9835 100644 --- a/tests/pr_test.go +++ b/tests/pr_test.go @@ -135,7 +135,6 @@ func TestFullyConfigurableInSchematics(t *testing.T) { }() options.TerraformVars = []testschematic.TestSchematicTerraformVar{ {Name: "ibmcloud_api_key", Value: options.RequiredEnvironmentVars["TF_VAR_ibmcloud_api_key"], DataType: "string", Secure: true}, - {Name: "existing_resource_group_name", Value: "Default", DataType: "string"}, {Name: "existing_kms_instance_crn", Value: permanentResources["hpcs_south_crn"], DataType: "string"}, {Name: "existing_cos_instance_crn", Value: permanentResources["general_test_storage_cos_instance_crn"], DataType: "string"}, {Name: "existing_cloud_logs_instance_crn", Value: terraform.Output(t, existingTerraformOptions, "icl_crn"), DataType: "string"}, @@ -193,7 +192,6 @@ func TestFullyConfigurableUpgradeInSchematics(t *testing.T) { options.TerraformVars = []testschematic.TestSchematicTerraformVar{ {Name: "ibmcloud_api_key", Value: options.RequiredEnvironmentVars["TF_VAR_ibmcloud_api_key"], DataType: "string", Secure: true}, - {Name: "existing_resource_group_name", Value: "Default", DataType: "string"}, {Name: "existing_kms_instance_crn", Value: permanentResources["hpcs_south_crn"], DataType: "string"}, {Name: "existing_cos_instance_crn", Value: permanentResources["general_test_storage_cos_instance_crn"], DataType: "string"}, {Name: "existing_cloud_logs_instance_crn", Value: terraform.Output(t, existingTerraformOptions, "icl_crn"), DataType: "string"}, From 50f4817029cf3454f30496c193b58caefc6aca93 Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Wed, 13 Aug 2025 12:55:06 +0530 Subject: [PATCH 06/10] remove account infra --- ibm_catalog.json | 27 +-------------------------- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/ibm_catalog.json b/ibm_catalog.json index c1ce94c9..a77768ea 100644 --- a/ibm_catalog.json +++ b/ibm_catalog.json @@ -113,7 +113,7 @@ { "key": "existing_resource_group_name", "type": "string", - "description": "Name of the existing resource group where add-ons will be deployed.", + "description": "Name of the existing resource group where dependent DA will be deployed.", "virtual": true, "default_value": "__NULL__" }, @@ -368,31 +368,6 @@ } ] }, - { - "name": "deploy-arch-ibm-account-infra-base", - "description": "Enable to create a resource groups by default where all the resources will be provisioned and, when you enable the “with Account Settings” option, it also applies baseline security and governance settings. When disabled, provide an existing resource group as input.", - "id": "63641cec-6093-4b4f-b7b0-98d2f4185cd6-global", - "version": "v3.0.7", - "flavors": [ - "resource-group-only", - "resource-groups-with-account-settings" - ], - "default_flavor": "resource-group-only", - "catalog_id": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3", - "optional": true, - "on_by_default": false, - "input_mapping": [ - { - "dependency_input": "prefix", - "version_input": "prefix", - "reference_version": true - }, - { - "dependency_output": "observability_resource_group_name", - "version_input": "existing_resource_group_name" - } - ] - }, { "name": "deploy-arch-ibm-cloud-logs", "description": "Enable this to create an IBM Cloud Logs (ICL) Instance which can be used for storage and analysis of events ingested by Activity Tracker. ", From 50ec8661a7f1d907847213c0e7b2f12c82343a42 Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Wed, 13 Aug 2025 12:59:48 +0530 Subject: [PATCH 07/10] resolve review comments --- ibm_catalog.json | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/ibm_catalog.json b/ibm_catalog.json index a77768ea..7ec7bffd 100644 --- a/ibm_catalog.json +++ b/ibm_catalog.json @@ -113,7 +113,7 @@ { "key": "existing_resource_group_name", "type": "string", - "description": "Name of the existing resource group where dependent DA will be deployed.", + "description": "The name of an existing resource group to provision the resources. If not provided the default resource group will be used.", "virtual": true, "default_value": "__NULL__" }, @@ -378,11 +378,6 @@ "optional": true, "on_by_default": true, "input_mapping": [ - { - "dependency_input": "existing_monitoring_crn", - "version_input": "existing_monitoring_crn", - "reference_version": true - }, { "dependency_input": "prefix", "version_input": "prefix", From bd4de4f0ee6f35f2216ec728dceff2669af10d89 Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Wed, 13 Aug 2025 17:07:44 +0530 Subject: [PATCH 08/10] resolve review comments --- ibm_catalog.json | 7 +++++-- solutions/fully-configurable/variables.tf | 7 ++++++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/ibm_catalog.json b/ibm_catalog.json index 7ec7bffd..cfe1ea19 100644 --- a/ibm_catalog.json +++ b/ibm_catalog.json @@ -160,8 +160,7 @@ ] }, { - "key": "existing_cloud_logs_instance_crn", - "required": true + "key": "existing_cloud_logs_instance_crn" }, { "key": "enable_activity_tracker_event_routing_to_cloud_logs" @@ -391,6 +390,10 @@ { "dependency_output": "cloud_logs_crn", "version_input": "existing_cloud_logs_instance_crn" + }, + { + "version_input": "enable_activity_tracker_event_routing_to_cloud_logs", + "value": true } ] }, diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf index 6b58f4db..405d9ea7 100644 --- a/solutions/fully-configurable/variables.tf +++ b/solutions/fully-configurable/variables.tf @@ -93,7 +93,12 @@ variable "enable_activity_tracker_event_routing_to_cos_bucket" { variable "enable_activity_tracker_event_routing_to_cloud_logs" { type = bool description = "Whether to enable event routing from Activity Tracker to Cloud Logs instance." - default = true + default = false + + validation { + condition = var.enable_activity_tracker_event_routing_to_cloud_logs ? var.existing_cloud_logs_instance_crn != null : true + error_message = "If 'enable_activity_tracker_event_routing_to_cloud_logs' is set to true, you must provide a value for 'existing_cloud_logs_instance_crn'." + } } variable "cos_target_name" { From 54d079d6238aa901694aed8871bff60d4c291c89 Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Wed, 13 Aug 2025 17:14:17 +0530 Subject: [PATCH 09/10] minor fixes --- tests/pr_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/pr_test.go b/tests/pr_test.go index b3bb9835..ab91918d 100644 --- a/tests/pr_test.go +++ b/tests/pr_test.go @@ -138,6 +138,7 @@ func TestFullyConfigurableInSchematics(t *testing.T) { {Name: "existing_kms_instance_crn", Value: permanentResources["hpcs_south_crn"], DataType: "string"}, {Name: "existing_cos_instance_crn", Value: permanentResources["general_test_storage_cos_instance_crn"], DataType: "string"}, {Name: "existing_cloud_logs_instance_crn", Value: terraform.Output(t, existingTerraformOptions, "icl_crn"), DataType: "string"}, + {Name: "enable_activity_tracker_event_routing_to_cloud_logs", Value: true, DataType: "bool"}, {Name: "kms_encryption_enabled_buckets", Value: true, DataType: "bool"}, {Name: "prefix", Value: options.Prefix, DataType: "string"}, {Name: "region", Value: options.Region, DataType: "string"}, @@ -195,6 +196,7 @@ func TestFullyConfigurableUpgradeInSchematics(t *testing.T) { {Name: "existing_kms_instance_crn", Value: permanentResources["hpcs_south_crn"], DataType: "string"}, {Name: "existing_cos_instance_crn", Value: permanentResources["general_test_storage_cos_instance_crn"], DataType: "string"}, {Name: "existing_cloud_logs_instance_crn", Value: terraform.Output(t, existingTerraformOptions, "icl_crn"), DataType: "string"}, + {Name: "enable_activity_tracker_event_routing_to_cloud_logs", Value: true, DataType: "bool"}, {Name: "kms_encryption_enabled_buckets", Value: true, DataType: "bool"}, {Name: "prefix", Value: options.Prefix, DataType: "string"}, {Name: "region", Value: options.Region, DataType: "string"}, From 3dd4af9679f596516588d2b707a48bf7521d89e6 Mon Sep 17 00:00:00 2001 From: Khuzaima-Shakeel Date: Wed, 13 Aug 2025 17:53:47 +0530 Subject: [PATCH 10/10] resolve review comments --- ibm_catalog.json | 4 +++ .../catalogValidationValues.json.template | 4 ++- solutions/fully-configurable/variables.tf | 25 +++++++++++++------ tests/pr_test.go | 2 ++ 4 files changed, 27 insertions(+), 8 deletions(-) diff --git a/ibm_catalog.json b/ibm_catalog.json index cfe1ea19..c8ea6e67 100644 --- a/ibm_catalog.json +++ b/ibm_catalog.json @@ -334,6 +334,10 @@ "dependency_input": "prefix", "version_input": "prefix", "reference_version": true + }, + { + "version_input": "enable_activity_tracker_event_routing_to_cos_bucket", + "value": true } ] }, diff --git a/solutions/fully-configurable/catalogValidationValues.json.template b/solutions/fully-configurable/catalogValidationValues.json.template index 5911cc0f..abfa62e7 100644 --- a/solutions/fully-configurable/catalogValidationValues.json.template +++ b/solutions/fully-configurable/catalogValidationValues.json.template @@ -4,5 +4,7 @@ "kms_encryption_enabled_buckets": true, "region": "us-south", "prefix": $PREFIX, - "existing_cos_instance_crn": $COS_INSTANCE_CRN + "existing_cos_instance_crn": $COS_INSTANCE_CRN, + "enable_activity_tracker_event_routing_to_cloud_logs": true, + "enable_activity_tracker_event_routing_to_cos_bucket": true } diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf index 405d9ea7..ce04a551 100644 --- a/solutions/fully-configurable/variables.tf +++ b/solutions/fully-configurable/variables.tf @@ -76,7 +76,7 @@ variable "existing_cloud_logs_instance_crn" { type = string nullable = true default = null - description = "The CRN of an existing Cloud logs instance." + description = "The CRN of an existing Cloud Logs instance. This value is required and cannot be null if `enable_activity_tracker_event_routing_to_cloud_logs` is set to true." } @@ -86,13 +86,24 @@ variable "existing_cloud_logs_instance_crn" { variable "enable_activity_tracker_event_routing_to_cos_bucket" { type = bool - description = "Whether to enable event routing from Activity Tracker to the Object Storage bucket." - default = true + description = "When set to `true`, you must provide a value for `existing_cos_instance_crn` to enable event routing from Activity Tracker to a Object Storage bucket." + default = false + + validation { + condition = var.enable_activity_tracker_event_routing_to_cos_bucket ? var.existing_cos_instance_crn != null : true + error_message = "If 'enable_activity_tracker_event_routing_to_cos_bucket' is set to true, you must provide a value for 'existing_cos_instance_crn'." + } + + validation { + condition = var.enable_activity_tracker_event_routing_to_cos_bucket || var.enable_activity_tracker_event_routing_to_cloud_logs + error_message = "At least one of 'enable_activity_tracker_event_routing_to_cos_bucket' or 'enable_activity_tracker_event_routing_to_cloud_logs' must be true to route audit events to COS bucket or Cloud Logs instance." + } + } variable "enable_activity_tracker_event_routing_to_cloud_logs" { type = bool - description = "Whether to enable event routing from Activity Tracker to Cloud Logs instance." + description = "When set to `true`, you must provide a value for `existing_cloud_logs_instance_crn` to enable event routing from Activity Tracker to a Cloud Logs instance." default = false validation { @@ -179,11 +190,11 @@ variable "activity_tracker_cos_target_bucket_class" { } } - variable "existing_cos_instance_crn" { type = string - description = "The CRN of an existing Cloud Object Storage instance." - nullable = false + nullable = true + default = null + description = "The CRN of an existing Cloud Object Storage instance. This value is required and cannot be null if `enable_activity_tracker_event_routing_to_cos_bucket` is set to true." } diff --git a/tests/pr_test.go b/tests/pr_test.go index ab91918d..b8645102 100644 --- a/tests/pr_test.go +++ b/tests/pr_test.go @@ -139,6 +139,7 @@ func TestFullyConfigurableInSchematics(t *testing.T) { {Name: "existing_cos_instance_crn", Value: permanentResources["general_test_storage_cos_instance_crn"], DataType: "string"}, {Name: "existing_cloud_logs_instance_crn", Value: terraform.Output(t, existingTerraformOptions, "icl_crn"), DataType: "string"}, {Name: "enable_activity_tracker_event_routing_to_cloud_logs", Value: true, DataType: "bool"}, + {Name: "enable_activity_tracker_event_routing_to_cos_bucket", Value: true, DataType: "bool"}, {Name: "kms_encryption_enabled_buckets", Value: true, DataType: "bool"}, {Name: "prefix", Value: options.Prefix, DataType: "string"}, {Name: "region", Value: options.Region, DataType: "string"}, @@ -197,6 +198,7 @@ func TestFullyConfigurableUpgradeInSchematics(t *testing.T) { {Name: "existing_cos_instance_crn", Value: permanentResources["general_test_storage_cos_instance_crn"], DataType: "string"}, {Name: "existing_cloud_logs_instance_crn", Value: terraform.Output(t, existingTerraformOptions, "icl_crn"), DataType: "string"}, {Name: "enable_activity_tracker_event_routing_to_cloud_logs", Value: true, DataType: "bool"}, + {Name: "enable_activity_tracker_event_routing_to_cos_bucket", Value: true, DataType: "bool"}, {Name: "kms_encryption_enabled_buckets", Value: true, DataType: "bool"}, {Name: "prefix", Value: options.Prefix, DataType: "string"}, {Name: "region", Value: options.Region, DataType: "string"},