- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3
refactor: Improve User experience #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /run pipeline | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 
I understand that you are making appconfig addons enabled, hence architecture diagram also needs to modify. 
- 
Please recheck the notes for the iam_permissions section in ibm_catalog.json. Does not look consistent the way it is written in others DA. I'll prefer to check those PRs (like ocp-ai) that is reviewed by content-reviewer. 
- 
One minor comment on features. Does it allow to create multiple collections or only one collection? Accordingly feature can be updated, if multiple collections are allowed.
| /run pipeline | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor points to clarify
| /run pipeline | 
| /run pipeline | 
| /run pipeline | 
| /run pipeline | 
| /run pipeline | 
All changes done and approval done by Matt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New approach we are rolling out is to set enable_platform_metrics to false by default please
| /run pipeline | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- enable_platform_metrics should be false by default
- Please remove the work-around for virtual inputs as it has been fixed by catalog team.
- As it is single service DA and as mentioned in instructions, we need to add some standard content with i icon. Thats missing, please refer instructions in the issue 13599.
- Short description - Creates and configures an App Configuration service on IBM Cloud with optional integration of observability
- As the service supports ca-monregion, do you need to addvpesupport too in providers.tf?
- DA-cbr_rules.md should have tag for account id and others as done here
| 
 done | 
| /run pipeline | 
| /run pipeline | 
| /run pipeline | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| 🎉 This PR is included in version 1.9.0 🎉 The release is available on: 
 Your semantic-release bot 📦🚀 | 


Description
Issue
The name app_config_cbr_rules to changes to cbr_rules to be consistent with other DAs . This change has been tested with the main branch and the plan only resulted in
update-in-placeand that too not because of the name change but because of the order ofrule_contexts. Also verified in the UI that the CBR rule was not re created with the Rule ID.Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR Updates the catalog json for improved DA User experience as well as updates the IAM permissions needed to successfully deploy the DA with add ons. Also the variable name
app_config_cbr_ruleshas been changed tocbr_rulesRun the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers