fix: Make disable_public_endpoint a required input exposed to the DA (#749)

Author: akocbek

ibm_catalog.json

@@ -447,6 +447,10 @@
               "key": "existing_cos_instance_crn",
               "required": true
             },
+            {
+              "key": "disable_public_endpoint",
+              "required": true
+            },
             {
               "key": "enable_platform_metrics",
               "type": "string",
@@ -592,9 +596,6 @@
             {
               "key": "use_private_endpoint"
             },
-            {
-              "key": "disable_public_endpoint"
-            },
             {
               "key": "cluster_config_endpoint_type",
               "options": [

solutions/fully-configurable/variables.tf

@@ -268,8 +268,8 @@ variable "use_private_endpoint" {
 
 variable "disable_public_endpoint" {
   type        = bool
-  description = "Whether access to the public service endpoint is disabled when the cluster is created. Does not affect existing clusters. You can't disable a public endpoint on an existing cluster, so you can't convert a public cluster to a private cluster. To change a public endpoint to private, create another cluster with this input set to `true`."
-  default     = false
+  description = "Whether access to the public service endpoint is disabled when the cluster is created. Does not affect existing clusters. You can't disable a public endpoint on an existing cluster, so you can't convert a public cluster to a private cluster. To change a public endpoint to private, create another cluster with this input set to `true`. Warning: Set this field to `false` if you want to retain public access to the cluster. Once the cluster is created, this cannot be changed."
+  default     = true
 }
 
 variable "cluster_config_endpoint_type" {