Skip to content

Commit 67c2b67

Browse files
authored
feat: allow OpenShift v4.18 cluster version (#715)
1 parent 5648fab commit 67c2b67

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

ibm_catalog.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,10 @@
193193
"key": "ocp_version",
194194
"required": true,
195195
"options": [
196+
{
197+
"displayname": "4.18",
198+
"value": "4.18"
199+
},
196200
{
197201
"displayname": "4.17",
198202
"value": "4.17"

tests/pr_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ const customsgExampleDir = "examples/custom_sg"
2828
const yamlLocation = "../common-dev-assets/common-go-assets/common-permanent-resources.yaml"
2929

3030
// Ensure there is one test per supported OCP version
31-
const ocpVersion1 = "4.17" // used by TestRunFullyConfigurable, TestRunUpgradeFullyConfigurable, TestFSCloudInSchematic and TestRunMultiClusterExample
32-
const ocpVersion2 = "4.16" // used by TestCustomSGExample and TestRunCustomsgExample
33-
const ocpVersion3 = "4.15" // used by TestRunAdvancedExample and TestCrossKmsSupportExample
34-
const ocpVersion4 = "4.14" // used by TestRunAddRulesToSGExample and TestRunBasicExample
31+
const ocpVersion1 = "4.18" // used by TestRunFullyConfigurable, TestRunUpgradeFullyConfigurable, TestFSCloudInSchematic and TestRunMultiClusterExample
32+
const ocpVersion2 = "4.17" // used by TestCustomSGExample and TestRunCustomsgExample
33+
const ocpVersion3 = "4.16" // used by TestRunAdvancedExample and TestCrossKmsSupportExample
34+
const ocpVersion4 = "4.15" // used by TestRunAddRulesToSGExample and TestRunBasicExample
3535

3636
var (
3737
sharedInfoSvc *cloudinfo.CloudInfoService

variables.tf

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,10 @@ variable "worker_pools" {
112112
for wp in var.worker_pools :
113113
(local.ocp_version_num == "4.14" && wp.operating_system == local.os_rhel) ||
114114
(local.ocp_version_num == "4.15" && contains([local.os_rhel, local.os_rhcos], wp.operating_system)) ||
115-
(contains(["4.16", "4.17"], local.ocp_version_num) && contains([local.os_rhel9, local.os_rhel, local.os_rhcos], wp.operating_system))
115+
(contains(["4.16", "4.17"], local.ocp_version_num) && contains([local.os_rhel9, local.os_rhel, local.os_rhcos], wp.operating_system)) ||
116+
(local.ocp_version_num == "4.18" && contains([local.os_rhel9, local.os_rhcos], wp.operating_system))
116117
])
117-
error_message = "Invalid operating system for the given OCP version. Ensure the OS is compatible with the OCP version. Supported compatible OCP version and OS are v4.14: (REDHAT_8_64); v4.15: (REDHAT_8_64, RHCOS) ; v4.16 and v4.17: (REDHAT_8_64, RHCOS, RHEL_9_64)"
118+
error_message = "Invalid operating system for the given OCP version. Ensure the OS is compatible with the OCP version. Supported compatible OCP version and OS are v4.14: (REDHAT_8_64); v4.15: (REDHAT_8_64, RHCOS) ; v4.16 and v4.17: (REDHAT_8_64, RHCOS, RHEL_9_64); v4.18: (RHCOS, RHEL_9_64)"
118119
}
119120

120121
validation {
@@ -200,6 +201,7 @@ variable "ocp_version" {
200201
var.ocp_version == "4.15",
201202
var.ocp_version == "4.16",
202203
var.ocp_version == "4.17",
204+
var.ocp_version == "4.18",
203205
])
204206
error_message = "The specified ocp_version is not of the valid versions."
205207
}

0 commit comments

Comments
 (0)