Skip to content

Conversation

@dishankkalra23
Copy link
Member

Description

This PR exposes CheckClusterIngressHealthy to the pr_test.go to know the ingress state of the cluster.

https://github.ibm.com/GoldenEye/issues/issues/10545

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Addition of getClusterIngress method to expose the ingress state of the cluster

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@dishankkalra23
Copy link
Member Author

/run pipeline

@dishankkalra23
Copy link
Member Author

Screenshot 2024-09-16 at 9 06 25 AM

Seems like an issue in validation added. Similar error can be seen in ocp-all-inclusive as well. Looking into this error.

@dishankkalra23
Copy link
Member Author

/run pipeline

@dishankkalra23
Copy link
Member Author

@toddgiguere Validation is now working properly. Can you please give a final review to this PR?

@dishankkalra23
Copy link
Member Author

/run pipeline

@dishankkalra23
Copy link
Member Author

/run pipeline

1 similar comment
@dishankkalra23
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member

/run pipeline

@dishankkalra23
Copy link
Member Author

PR has been failing continuously due to an error. I will re-run it later to check if it gets rectify.

@dishankkalra23
Copy link
Member Author

/run pipeline

@Aashiq-J Aashiq-J merged commit fd7caaa into main Oct 29, 2024
2 checks passed
@Aashiq-J Aashiq-J deleted the expose-clusterIngress branch October 29, 2024 12:01
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.34.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants