mandate os input #516
Merged
mandate os input #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aayush-Abhyarthi
requested review from
Aashiq-J and
toddgiguere
as code owners
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
Aashiq-J
previously approved these changes
Oct 7, 2024
ocofaigh
requested changes
Oct 7, 2024
|
/run pipeline |
ocofaigh
approved these changes
Oct 9, 2024
|
🎉 This PR is included in version 3.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Wondering if setting a default value for the operating system (with the default value used when not specified before this change) would have been a less disruptive change for existing adopters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#475
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR mandates user to provide the operating system for additional worker pools.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers