Skip to content

Conversation

@iamar7
Copy link
Member

@iamar7 iamar7 commented Oct 10, 2024

Description

The module needs to be updated to no longer use LogDNA or Activity Tracker in the examples.

Issue: https://github.ibm.com/GoldenEye/issues/issues/11113

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7
Copy link
Member Author

iamar7 commented Oct 11, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Oct 11, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Oct 11, 2024

The TestRunUpgradeAdvancedExample is failing with the following error. Looking into the reason behind the failure.

Screenshot 2024-10-11 at 5 47 48 PM

@iamar7
Copy link
Member Author

iamar7 commented Oct 15, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Oct 15, 2024

/run pipeline

@iamar7 iamar7 marked this pull request as ready for review October 15, 2024 09:00
@iamar7
Copy link
Member Author

iamar7 commented Oct 15, 2024

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to provision any Observability instances anymore in the fscloud example. The only place thats left is here, but its no longer required to explicitly pass a monitoring CRN to enable monitoring on a bucket.

@iamar7
Copy link
Member Author

iamar7 commented Oct 15, 2024

/run pipeline

@iamar7 iamar7 self-assigned this Oct 15, 2024
@ocofaigh ocofaigh merged commit d37ea00 into main Oct 16, 2024
2 checks passed
@ocofaigh ocofaigh deleted the 11113-hp branch October 16, 2024 08:25
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants