-
Notifications
You must be signed in to change notification settings - Fork 14
fix: remove logdna and AT from fscloud example #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to provision any Observability instances anymore in the fscloud example. The only place thats left is here, but its no longer required to explicitly pass a monitoring CRN to enable monitoring on a bucket.
|
/run pipeline |
|
🎉 This PR is included in version 3.34.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |

Description
The module needs to be updated to no longer use LogDNA or Activity Tracker in the examples.
Issue: https://github.ibm.com/GoldenEye/issues/issues/11113
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers