Skip to content

Conversation

@Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Dec 17, 2024

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

=== NAME  TestRunUpgradeAdvancedExample
    terraform.go:243: 
        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/[email protected]/testhelper/terraform.go:243
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/[email protected]/testhelper/tests.go:620
        	            				/__w/terraform-ibm-base-ocp-vpc/terraform-ibm-base-ocp-vpc/tests/pr_test.go:111
        	Error:      	Should be false
        	Test:       	TestRunUpgradeAdvancedExample
        	Messages:   	Resource(s) identified to be updated 
        	            	Name: autoscaling_cluster
        	            	Address: module.ocp_base.ibm_container_vpc_cluster.autoscaling_cluster[0]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"kms_config":"SECURE_VALUE_HIDDEN_HASH:-5967978a5d51893d18294a730f0c55f16f7004d288ac24b9c98cfe5f"}
        	            	  After: 
        	            		{"kms_config":"SECURE_VALUE_HIDDEN_HASH:-b5cea1b586e5823f80001379addc0cfcc0a8cf4d7fa0a0d9bf0501b6"}
        	            	
        	            	Change Detail:
        	            	{
        	            	  "actions": [
        	            	    "update"
        	            	  ],

since the wait_for_apply default value is true, it will cause the upgrade test to fail.
skipping upgrade test

@Aashiq-J
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit df24ca7 into main Dec 17, 2024
2 checks passed
@ocofaigh ocofaigh deleted the kms-config branch December 17, 2024 19:53
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.35.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants