feat: add support for deploying ocp in custom cloud endpoints #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/run pipeline |
Member
Author
|
/run pipeline |
1 similar comment
Member
Author
|
/run pipeline |
Member
Author
|
/run pipeline |
Member
Author
|
/run pipeline |
vbontempi
reviewed
Jan 7, 2025
vbontempi
requested changes
Jan 7, 2025
Member
vbontempi
left a comment
vbontempi
left a comment
There was a problem hiding this comment.
I am not sure this is the right way to address it, we should make the script to verify the value of an env var and to fall back to the default value if not set
More, we mustn't expose not public endpoints on public code/documentation
Member
Author
|
/run pipeline |
Member
Author
|
/run pipeline |
1 similar comment
Member
Author
|
/run pipeline |
vbontempi
reviewed
Jan 9, 2025
vbontempi
reviewed
Jan 9, 2025
vbontempi
reviewed
Jan 9, 2025
Member
vbontempi
left a comment
vbontempi
left a comment
There was a problem hiding this comment.
just a comment, the changes are ok for me now
Member
Author
|
/run pipeline |
Contributor
|
🎉 This PR is included in version 3.36.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to deploy to custom cloud endpoint.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers