Skip to content

Conversation

@Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Jan 29, 2025

Description

updated code to use cross-object referencing for validations

issue: https://github.ibm.com/orgs/GoldenEye/projects/3/views/1?filterQuery=assignee%3A%40me&pane=issue&itemId=571033

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05 Khuzaima05 self-assigned this Jan 29, 2025
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

1 similar comment
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Jan 30, 2025

I have updated the provider_visibility for fscloud test as per discussion : https://ibm-cloudplatform.slack.com/archives/CG06FQ31P/p1738167104080339

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

2 similar comments
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other validation in main.tf (search for the string # tflint-ignore: terraform_unused_declarations to find them all)

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

What about the other validation in main.tf (search for the string # tflint-ignore: terraform_unused_declarations to find them all)

@ocofaigh ,Since those variables are validating local variables rather than variables in variables.tf, cross-object referencing in variables.tf is not possible for them.

Screenshot 2025-02-06 at 12 10 09 PM

@Khuzaima05
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh mentioned this pull request Feb 7, 2025
6 tasks
@Khuzaima05
Copy link
Member Author

/run pipeline

1 similar comment
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Contributor

/run pipeline

@ocofaigh ocofaigh merged commit 949c1d6 into main Feb 10, 2025
2 checks passed
@ocofaigh ocofaigh deleted the issue_10941 branch February 10, 2025 18:26
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.41.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants