Skip to content

Conversation

@Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented Feb 6, 2025

Description

This PR introduces a fully configurable deployable architecture (DA) for Red Hat OpenShift Container Platform (OCP) on IBM Cloud.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content
  • Fully configurable variant along with Red Hat Openshift AI add-on support.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Ak-sky
Copy link
Member Author

Ak-sky commented Feb 6, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Feb 6, 2025

/run pipeline

1 similar comment
@Ak-sky
Copy link
Member Author

Ak-sky commented Feb 6, 2025

/run pipeline

@Ak-sky Ak-sky marked this pull request as ready for review February 6, 2025 08:58
@Ak-sky
Copy link
Member Author

Ak-sky commented Feb 6, 2025

/run pipeline

@Ak-sky Ak-sky changed the title feat: ocp-quick-start-DA [WIP]feat: ocp-quick-start-DA Feb 6, 2025
@Ak-sky Ak-sky changed the title [WIP]feat: ocp-quick-start-DA feat: ocp-quick-start-DA Feb 9, 2025
@Ak-sky
Copy link
Member Author

Ak-sky commented Feb 9, 2025

/run pipeline

@imprateeksh
Copy link
Member

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the icon needs to be fixed (same fix you made for OCP AI DA)

@imprateeksh
Copy link
Member

Successfully ran all tests under other_tests.go locally to ensure nothing breaks.
Test Results: test-results-local.txt

@imprateeksh
Copy link
Member

/run pipeline

@imprateeksh imprateeksh self-assigned this Apr 1, 2025
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like pre-validation-deploy-cos-instance-and-vpc.sh is out of date with required inputs. Its not passing a value for existing_vpc_crn so validation fails with:

2025/04/01 14:21:10 Terraform plan | Error: Missing required argument
 2025/04/01 14:21:10 Terraform plan | 
 2025/04/01 14:21:10 Terraform plan |   with module.ocp_base.ibm_container_vpc_cluster.cluster[0],
 2025/04/01 14:21:10 Terraform plan |   on ../../main.tf line 140, in resource "ibm_container_vpc_cluster" "cluster":
 2025/04/01 14:21:10 Terraform plan |  140:   vpc_id                              = var.vpc_id

@imprateeksh
Copy link
Member

/run pipeline

@imprateeksh
Copy link
Member

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make the pre AND post scripts executable: ./catalog-onboard.sh: line 1087: tests/scripts/pre-validation-deploy-cos-instance-and-vpc.sh: Permission denied

@imprateeksh
Copy link
Member

/run pipeline

@vkuma17
Copy link
Contributor

vkuma17 commented Apr 2, 2025

/run pipeline

@vkuma17
Copy link
Contributor

vkuma17 commented Apr 2, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 0eaa7ee into main Apr 2, 2025
2 checks passed
@ocofaigh ocofaigh deleted the qs branch April 2, 2025 07:23
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.