-
Notifications
You must be signed in to change notification settings - Fork 14
feat: ocp fully-configurable DA #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the icon needs to be fixed (same fix you made for OCP AI DA)
|
Successfully ran all tests under |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like pre-validation-deploy-cos-instance-and-vpc.sh is out of date with required inputs. Its not passing a value for existing_vpc_crn so validation fails with:
2025/04/01 14:21:10 Terraform plan | Error: Missing required argument
2025/04/01 14:21:10 Terraform plan |
2025/04/01 14:21:10 Terraform plan | with module.ocp_base.ibm_container_vpc_cluster.cluster[0],
2025/04/01 14:21:10 Terraform plan | on ../../main.tf line 140, in resource "ibm_container_vpc_cluster" "cluster":
2025/04/01 14:21:10 Terraform plan | 140: vpc_id = var.vpc_id
|
/run pipeline |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to make the pre AND post scripts executable: ./catalog-onboard.sh: line 1087: tests/scripts/pre-validation-deploy-cos-instance-and-vpc.sh: Permission denied
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 3.43.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
This PR introduces a fully configurable deployable architecture (DA) for
Red Hat OpenShift Container Platform (OCP)on IBM Cloud.Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers