Skip to content

Conversation

@Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Feb 18, 2025

Description

add support for orphan_on_delete to handle the default worker error

The action cannot be completed because it would reduce the worker pool's size below the cluster's minimum requirement of 2 workers. If there are any worker operations pending, you might need wait for them to complete.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

2025-02-18T07:54:55.7306363Z         	Test:       	TestRunUpgradeAdvancedExample
2025-02-18T07:54:55.7307038Z         	Messages:   	Resource(s) identified to be updated 
2025-02-18T07:54:55.7307810Z         	            	Name: autoscaling_pool
2025-02-18T07:54:55.7308344Z         	            	Address: module.ocp_base.ibm_container_vpc_worker_pool.autoscaling_pool["default"]
2025-02-18T07:54:55.7308772Z         	            	Actions: [update]
2025-02-18T07:54:55.7309031Z         	            	DIFF:
2025-02-18T07:54:55.7309258Z         	            	  Before: 
2025-02-18T07:54:55.7309508Z         	            		{"orphan_on_delete":null}
2025-02-18T07:54:55.7309786Z         	            	  After: 
2025-02-18T07:54:55.7310024Z         	            		{"orphan_on_delete":true}
2025-02-18T07:54:55.7310282Z         	            	

upgrade test is failing due to the update-in-place for the workerpool. This is expected.

@Aashiq-J
Copy link
Member Author

/run pipeline

1 similar comment
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@vburckhardt
Copy link
Member

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@vburckhardt vburckhardt merged commit ef733dd into main Feb 26, 2025
2 checks passed
@vburckhardt vburckhardt deleted the on_delete branch February 26, 2025 12:06
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.41.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Ak-sky pushed a commit that referenced this pull request Mar 4, 2025
…han_on_delete` provider property (#597)

* feat: add support for `orphan_on_delete` for default worker pool

* update common-dev-asset to fix the golint issue

* SKIP UPGRADE TEST

* increase timeout

* update readme

---------

Co-authored-by: Vincent Burckhardt <[email protected]>
@Ak-sky Ak-sky mentioned this pull request Mar 6, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants