[Do Not Merge]-Added Openshift-ai addon #598
Conversation
|
/run pipeline |
imprateeksh
left a comment
imprateeksh
left a comment
There was a problem hiding this comment.
Please check the comments.
examples/advanced/main.tf
Outdated
| ignore_worker_pool_size_changes = true | ||
| addons = { | ||
| "cluster-autoscaler" = "1.2.3" | ||
| "openshift-ai" = "416" |
There was a problem hiding this comment.
Please do not make changes in existing examples unless required.
solutions/ocp-ai/main.tf
Outdated
| #tflint-ignore: terraform_unused_declarations | ||
| resource "null_resource" "validations" { | ||
| provisioner "local-exec" { | ||
| #command = "scripts/validations.sh ${local.ocp_version} ${local.worker_pool[0].worker_count} ${local.worker_pool[0].flavor} '${join(" ", [for addon in data.ibm_container_addons.addons.addons : addon.name])}' ${local.worker_pool[0].operating_system} ${var.pool_name}" |
solutions/ocp-ai/main.tf
Outdated
|
|
||
| addons { | ||
| name = "openshift-ai" | ||
| version = "416" |
There was a problem hiding this comment.
Do not hardcode the version instead use a variable for ocp ai addon version.
solutions/ocp-ai/main.tf
Outdated
| kubeconfig = "../../kubeconfig" | ||
| } | ||
| #tflint-ignore: terraform_unused_declarations | ||
| resource "null_resource" "validations" { |
There was a problem hiding this comment.
Suggest to use a better name for resource something like validate_cluster or validate_cluster_specs
| @@ -0,0 +1,14 @@ | |||
| terraform { | |||
| required_version = ">= 1.3.0" | |||
There was a problem hiding this comment.
Please make use of version 1.9.0 and utilize the cross referencing feature when required.
| } | ||
| variable "cluster_name" { | ||
| type = string | ||
| description = "The name that will be assigned to the provisioned cluster" |
There was a problem hiding this comment.
Please correct the description - The name of the existing cluster.
solutions/ocp-ai/variables.tf
Outdated
| } | ||
| variable "pool_name" { | ||
| type = string | ||
| description = "The name that will be assigned to the worker pool" |
There was a problem hiding this comment.
Please improvise this description.
| cluster-autoscaler = optional(string) | ||
| vpc-block-csi-driver = optional(string) | ||
| ibm-storage-operator = optional(string) | ||
| openshift-ai = optional(string) |
There was a problem hiding this comment.
We can omit including openshift-ai here. We will use addon DA to include this.
solutions/ocp-ai/main.tf
Outdated
| ocp_version = data.ibm_container_cluster_versions.cluster_versions.default_openshift_version | ||
| kubeconfig = "../../kubeconfig" | ||
| } | ||
| #tflint-ignore: terraform_unused_declarations |
There was a problem hiding this comment.
Can we not remove this comment unless really required?
solutions/ocp-ai/main.tf
Outdated
| @@ -0,0 +1,49 @@ | |||
| # Retrieve existing OpenShift cluster details | |||
There was a problem hiding this comment.
In this code, we do not have changes for new cluster scenario. Please add the resources for the use case where a new cluster is created.
arya-girish-k
changed the title
|
Closing this PR as it is no longer required. OCP AI related validations are already included in this module. |
Description
Added Openshift-ai addon
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers