Skip to content

Conversation

@imprateeksh
Copy link
Member

@imprateeksh imprateeksh commented Feb 24, 2025

Description

Updated the script by removing exponential backoff time and scoping the retry_wait time to respective functions.
Issue - #599

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@imprateeksh
Copy link
Member Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add validation to the script to check for required environment variables? I tried to run it locally and got this:

=========================================
/tmp/test.sh: line 63: ENABLE_OCP_CONSOLE: unbound variable

Other than that set the wait time back to 5 seconds and we should be good

@imprateeksh
Copy link
Member Author

/run pipeline

@imprateeksh
Copy link
Member Author

Can we add validation to the script to check for required environment variables? I tried to run it locally and got this:

=========================================
/tmp/test.sh: line 63: ENABLE_OCP_CONSOLE: unbound variable

Other than that set the wait time back to 5 seconds and we should be good

Thank you for mentioning this Conall. Made the change, error message now:

image

@imprateeksh
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 29f6f84 into main Feb 25, 2025
2 checks passed
@ocofaigh ocofaigh deleted the fix-retry-err branch February 25, 2025 07:47
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.41.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants