Skip to content

feat: add sub-module to enable kube-audit in base-ocp clusters #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Apr 16, 2025
Merged

feat: add sub-module to enable kube-audit in base-ocp clusters #619

merged 53 commits into from
Apr 16, 2025

Conversation

@Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Mar 19, 2025 •
edited
Loading

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J Aashiq-J marked this pull request as ready for review March 20, 2025 05:53
@Aashiq-J Aashiq-J requested a review from toddgiguere as a code owner March 20, 2025 05:53
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

tested the complete end-to-end solution.
Screenshot 2025-03-19 at 9 44 32 PM
Screenshot 2025-03-19 at 1 41 35 PM

ocofaigh
ocofaigh requested changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

Should we have the root module call the submodule and enable it by default?

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Apr 3, 2025

/run pipeline

1 similar comment
@Aashiq-J
Copy link
Member Author

Aashiq-J commented Apr 3, 2025

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Apr 3, 2025

/run pipeline

1 similar comment
@Aashiq-J
Copy link
Member Author

Aashiq-J commented Apr 4, 2025

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Apr 4, 2025

/run pipeline

toddgiguere
toddgiguere previously approved these changes Apr 4, 2025
View reviewed changes
@Aashiq-J
Copy link
Member Author

Aashiq-J commented Apr 7, 2025

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Apr 8, 2025

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit fb65659 into main Apr 16, 2025
2 checks passed
@ocofaigh ocofaigh deleted the audit branch April 16, 2025 09:59
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@toddgiguere toddgiguere toddgiguere approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Aashiq-J @terraform-ibm-modules-ops @ocofaigh @toddgiguere @imprateeksh