Skip to content

Conversation

@imprateeksh
Copy link
Member

@imprateeksh imprateeksh commented May 14, 2025

Description

In this PR, the logic to handle various kinds of machine_types is improvised else it would fail the validation in certain scenarios.
Also the default_secondary_storage is now removed which was used along with default machine type to address ocp-ai changes. As GPUs will be included in additional worker pools, secondary storage can be provided there.

Internal issue Reference - Issue-13375

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content
  • Updated validation logic to get CPU and RAM from machine types.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@imprateeksh imprateeksh self-assigned this May 14, 2025
@imprateeksh
Copy link
Member Author

Tried the validation cases locally for different machine types like below:

"mx2.16x128.2000gb", "mx2d.metal.96x768" , "bx2.8x32", "gx3.16x80.l4"
image

@imprateeksh
Copy link
Member Author

/run pipeline

@imprateeksh imprateeksh changed the title refactor: updated validation logic fix: updated validation logic May 15, 2025
@imprateeksh
Copy link
Member Author

/run pipeline

@toddgiguere
Copy link
Member

/run pipeline

@imprateeksh
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 7765d40 into main May 16, 2025
2 checks passed
@ocofaigh ocofaigh deleted the ocp-ai-fixes branch May 16, 2025 15:10
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.47.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants