Skip to content

Conversation

@toddgiguere
Copy link
Member

Description

This is an update to the most recent version of the IBM-Cloud Terraform provider which includes a bug fix to the attach of security groups to a load balancer not in "active" state.

As a result of this provider bug fix, the workaround script in this module to also solve this problem has been removed.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@toddgiguere toddgiguere requested a review from Aashiq-J as a code owner May 14, 2025 15:52
@toddgiguere
Copy link
Member Author

TEST NOTES:

Since we have removed a null_resource block as part of this upgrade, I'm expecting the upgrade test to fail. I'm going to first run the tests and report back that the blocks we removed were the only upgrade failures.

Also, the change made in provider are primarily tested with a unit test in the other_test.go set of tests that are not run during the PR pipeline. I will execute these tests manually and report back the result in a future comment.

@toddgiguere
Copy link
Member Author

/run pipeline

@toddgiguere
Copy link
Member Author

Initial tests passed, including upgrade and the custom_sg example that would have been affected by these changes.

The only test fail was in the regular full config test, but not due to any issues caused by these changes, it was caused by an issue with downloading a module from the terraform registry.

Will run pipeline again as-is.

@toddgiguere
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Contributor

         2025/05/14 20:24:17 Terraform init | Error: Failed to download module
         2025/05/14 20:24:17 Terraform init | 
         2025/05/14 20:24:17 Terraform init |   on ../../main.tf line 107:
         2025/05/14 20:24:17 Terraform init |  107: module "cos_instance" {
         2025/05/14 20:24:17 Terraform init | 
         2025/05/14 20:24:17 Terraform init | Could not download module "cos_instance" (../../main.tf:107) source code from
         2025/05/14 20:24:17 Terraform init | "git::https://github.com/terraform-ibm-modules/terraform-ibm-cos?ref=21406c6fefc5f670167b0e1dcd5aa63f5930fbd4":
         2025/05/14 20:24:17 Terraform init | error downloading
         2025/05/14 20:24:17 Terraform init | 'https://github.com/terraform-ibm-modules/terraform-ibm-cos?ref=21406c6fefc5f670167b0e1dcd5aa63f5930fbd4':
         2025/05/14 20:24:17 Terraform init | /usr/bin/git exited with 128: Cloning into
         2025/05/14 20:24:17 Terraform init | '.terraform/modules/ocp_base.cos_instance'...
         2025/05/14 20:24:17 Terraform init | fatal: unable to access
         2025/05/14 20:24:17 Terraform init | 'https://github.com/terraform-ibm-modules/terraform-ibm-cos/': Failed to
         2025/05/14 20:24:17 Terraform init | connect to github.com port 443: Connection timed out

Retrying..

@ocofaigh ocofaigh merged commit 0d6fce6 into main May 15, 2025
2 checks passed
@ocofaigh ocofaigh deleted the rm-lb-workaround branch May 15, 2025 09:12
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.46.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants