Skip to content

Conversation

@Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Jun 20, 2025

Description

Since we are facing blocker in managing the odf addon version. We have decided to manage the odf version in the OCP DA, this will add odf version only if the user passed null value for the odf version.

Addressed this issue as well in this PR.
Issue: #708

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J Aashiq-J requested a review from toddgiguere as a code owner June 20, 2025 17:13
@Aashiq-J
Copy link
Member Author

/run pipeline

1 similar comment
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

1 similar comment
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member

@Aashiq-J
why do we need to add subnets variable in OCP DA? virtual input wont help?

@Aashiq-J
Copy link
Member Author

@maheshwarishikha
The subnets variable is complex data type, is that supported in catalog json?
I taught only basic data types are supported.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jul 3, 2025

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jul 8, 2025

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J Aashiq-J requested a review from toddgiguere July 11, 2025 08:06
@Aashiq-J
Copy link
Member Author

/run pipeline

1 similar comment
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J Aashiq-J merged commit 2f339be into main Jul 17, 2025
2 checks passed
@Aashiq-J Aashiq-J deleted the odf branch July 17, 2025 09:19
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants