Skip to content

Conversation

@Aditya-ranjan-16
Copy link
Contributor

@Aditya-ranjan-16 Aditya-ranjan-16 commented Jul 17, 2025

Description

https://github.ibm.com/GoldenEye/issues/issues/14049

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aditya-ranjan-16 Aditya-ranjan-16 marked this pull request as ready for review July 24, 2025 05:52
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rename the folder reference-architecture -> reference-architectures for the docs automation to pick it up

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 4, 2025

@Aditya-ranjan-16 Please also add the release notes link. Same as terraform-ibm-modules/terraform-ibm-landing-zone-vpc#1049

Also a reminder that we are still waiting on #773 to be merged first

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 9, 2025

@Aditya-ranjan-16 #773 has just been merged - can you get this and terraform-ibm-modules/terraform-ibm-landing-zone#1022 ready to go now please?

@maheshwarishikha
Copy link
Member

@Aditya-ranjan-16 #780 has also been merged. We are good for migration activity. Please update this PR.

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

ocofaigh
ocofaigh previously approved these changes Sep 10, 2025
@maheshwarishikha
Copy link
Member

/run pipeline

@ocofaigh ocofaigh merged commit a7c27e9 into main Sep 10, 2025
1 of 2 checks passed
@ocofaigh ocofaigh deleted the landing-zone-variation branch September 10, 2025 10:31
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.58.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants