Skip to content

feat: Quickstart OCP DA #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Aug 8, 2025
Merged

feat: Quickstart OCP DA #738

merged 45 commits into from
Aug 8, 2025

Conversation

@arya-girish-k
Copy link
Contributor

Description

https://github.ibm.com/GoldenEye/issues/issues/14936

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

Aashiq-J
Aashiq-J reviewed Jul 24, 2025
View reviewed changes
ibm_catalog.json Outdated
},
{
"key": "cluster_name",
"hidden":true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this hidden?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned , I have added the relevant variables to the required and optional tabs. However, I updated this particular variable to be optional

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

Some of the tests were failing with this error :

        	            	│ Error: Request failed with status code: 500, ServerErrorResponse: {"incidentID":"929e012f-4e16-ab2c-8714-a7e8f760ab6e","code":"Ed196","description":"Could not connect to a backend service. Try again later.","type":""}
        	            	│
        	            	│   with module.ocp_base.ibm_container_vpc_cluster.cluster[0],
        	            	│   on ../../main.tf line 128, in resource "ibm_container_vpc_cluster" "cluster":
        	            	│  128: resource "ibm_container_vpc_cluster" "cluster" {
        	            	│
        	            	│ ---
        	            	│ id: terraform-40a3a1fe
        	            	│ summary: 'Request failed with status code: 500, ServerErrorResponse:
        	            	│ {"incidentID":"929e012f-4e16-ab2c-8714-a7e8f760ab6e","code":"Ed196","description":"Could
        	            	│   not connect to a backend service. Try again later.","type":""}'

As per the thread added the temporary workaround

@arya-girish-k
Copy link
Contributor Author

The upgrade test is failing because it clones the main branch and looks for the Quickstart DA repo, which doesn’t exist in main yet—we’re introducing it in our current branch. Hence, we are skipping the upgrade test.
image

@arya-girish-k
Copy link
Contributor Author

/run pipeline

pranjali-mundra
pranjali-mundra reviewed Aug 7, 2025
View reviewed changes
@arya-girish-k
Copy link
Contributor Author

/run pipeline

ocofaigh
ocofaigh previously approved these changes Aug 7, 2025
View reviewed changes
@arya-girish-k
Copy link
Contributor Author

/run pipeline

maheshwarishikha
maheshwarishikha reviewed Aug 8, 2025
View reviewed changes
maheshwarishikha
maheshwarishikha reviewed Aug 8, 2025
View reviewed changes
maheshwarishikha
maheshwarishikha reviewed Aug 8, 2025
View reviewed changes
maheshwarishikha
maheshwarishikha reviewed Aug 8, 2025
View reviewed changes
maheshwarishikha
maheshwarishikha reviewed Aug 8, 2025
View reviewed changes
maheshwarishikha
maheshwarishikha requested changes Aug 8, 2025
View reviewed changes
Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add DA outputs

arya-girish-k and others added 4 commits August 8, 2025 09:41
@arya-girish-k
Copy link
Contributor Author

Please add DA outputs

Added

@arya-girish-k
Copy link
Contributor Author

image

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@maheshwarishikha maheshwarishikha merged commit c131db2 into main Aug 8, 2025
2 checks passed
@maheshwarishikha maheshwarishikha deleted the quickstart-ocp branch August 8, 2025 07:26
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.55.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maheshwarishikha maheshwarishikha maheshwarishikha approved these changes

@ocofaigh ocofaigh ocofaigh approved these changes

@Aashiq-J Aashiq-J Aashiq-J left review comments

@toddgiguere toddgiguere Awaiting requested review from toddgiguere toddgiguere is a code owner

+1 more reviewer

@pranjali-mundra pranjali-mundra pranjali-mundra left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@arya-girish-k @terraform-ibm-modules-ops @maheshwarishikha @ocofaigh @Aashiq-J @pranjali-mundra