- 
                Notifications
    You must be signed in to change notification settings 
- Fork 14
fix: Improved error handling in reset_iks_api_key.sh #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /run pipeline | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion would be to add a retry block similar to what we have when we reset the keys.
@ocofaigh , thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should add a retry and if it fails, echo the response.
| /run pipeline | 
| /run pipeline | 
| /run pipeline | 
    
      
        1 similar comment
      
    
  
    | /run pipeline | 
| /run pipeline | 
| 🎉 This PR is included in version 3.55.2 🎉 The release is available on: 
 Your semantic-release bot 📦🚀 | 
Description
#710
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR improves IAM error handling in the script reset_iks_api_key.sh
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers