-
Notifications
You must be signed in to change notification settings - Fork 13
feat: add support for major openshift version upgrade #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments below also add some documentation on how to migrate, and consider adding a migration helper script
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
This also only requires a minor release, not a major one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this got to the state where it needs to be. This needs to go ahead when pipeline passes, as going since August.
|
/run pipeline |
|
🎉 This PR is included in version 3.64.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Add Opt-In Support for major openShift version upgrades via terraform
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR introduces a new variable,
enable_openshift_version_upgrade, which allows users to perform openshift version upgrades with Terraform. However, whenenable_openshift_version_upgradeis set to true, Terraform may plan to destroy and re-create the cluster because the resource type in the module changes. To prevent this, you must migrate the existing state to the new resource address before applying any changes. This is a one time migration of the state.There are several options to do this:
Use terraform moved blocks (recommended)
The recommended approach is to use Terraform's native moved block feature:
Example assuming your OCP module is called "ocp"
For auto-scaling clusters:
Add this block to your Terraform configuration, run terraform plan to verify the state migration, then terraform apply to apply the changes. This approach works for both local Terraform and Schematics deployments.
Perform manual state migration
For a standard cluster
For an autoscaling cluster
After migrating the state, run a
terraform refreshto synchronize the state file with the actual cluster. For more details refer here.Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers